Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dev-v2.8] rancher-backup 103.0.2+up4.0.2 update #3839

Merged
merged 2 commits into from
May 7, 2024
Merged

[dev-v2.8] rancher-backup 103.0.2+up4.0.2 update #3839

merged 2 commits into from
May 7, 2024

Conversation

mallardduck
Copy link
Member

No description provided.

@mallardduck mallardduck requested review from a team as code owners April 29, 2024 21:21
@github-actions GitHub Actions
Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

lucasmlp
lucasmlp approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@lucasmlp lucasmlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2024

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

ericpromislow
ericpromislow approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@ericpromislow ericpromislow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericpromislow ericpromislow merged commit 5fa17f9 into rancher:dev-v2.8 May 7, 2024
6 checks passed
lucasmlp pushed a commit that referenced this pull request May 7, 2024
@mallardduck @lucasmlp
[dev-v2.8] rancher-backup 103.0.2+up4.0.2 update (#3839)
7ec666f
@lucasmlp lucasmlp mentioned this pull request May 7, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericpromislow ericpromislow ericpromislow approved these changes

@lucasmlp lucasmlp lucasmlp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mallardduck @ericpromislow @lucasmlp