Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev-v2.9] Annotation fix #3840

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Conversation

joshmeranda
Copy link
Contributor

Issue:

Problem

We had the wrong supported kube-version for rancher-monitoring blocking install via UI.

Solution

Testing

Engineering Testing

Manual Testing

Automated Testing

QA Testing Considerations

Regressions Considerations

Backporting considerations

@joshmeranda joshmeranda requested a review from a team as a code owner April 30, 2024 19:15
Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@joshmeranda joshmeranda merged commit 5b9884b into rancher:dev-v2.9 Apr 30, 2024
6 checks passed
krunalhinguu pushed a commit to krunalhinguu/charts that referenced this pull request May 14, 2024
Co-authored-by: joshmeranda <joshua.meranda@gmail.com>
@joshmeranda joshmeranda deleted the annotation-fix branch June 28, 2024 13:48
krunalhinguu pushed a commit to krunalhinguu/charts that referenced this pull request Jul 15, 2024
Co-authored-by: joshmeranda <joshua.meranda@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants