[dev-v2.7] Fix patch failures for newer versions of charts-build-scripts #4014

nicholasSUSE · 2024-06-04T19:11:59Z

Problem

We have a series of charts that should have been updated to not break the CI.
Their packages folder needed to adapt to the new versions of charts-build-scripts

Solution

Provide the necessary adaptations for the charts in the packages folder when possible.

Release a new patch update when just updating the packages is not possible.

github-actions · 2024-06-04T19:12:11Z

Validation steps

Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.

  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913

Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
Approve the PR to run the CI check.

github-actions · 2024-06-04T19:25:47Z

Validation steps

Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.

  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913

Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
Approve the PR to run the CI check.

github-actions · 2024-06-04T19:29:22Z

Validation steps

Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.

  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913

Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
Approve the PR to run the CI check.

github-actions · 2024-06-04T19:32:41Z

Validation steps

Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.

  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913

Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
Approve the PR to run the CI check.

github-actions · 2024-06-04T19:36:31Z

Validation steps

Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.

  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913

Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
Approve the PR to run the CI check.

w13915984028

Harvester-cloud-provider looks good, thanks.

github-actions · 2024-06-04T19:44:43Z

Validation steps

Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.

  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913

Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
Approve the PR to run the CI check.

github-actions · 2024-06-04T19:54:54Z

Validation steps

Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.

  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913

Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
Approve the PR to run the CI check.

github-actions · 2024-06-04T20:01:15Z

Validation steps

Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.

  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913

Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
Approve the PR to run the CI check.

github-actions · 2024-06-04T20:02:45Z

Validation steps

Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.

  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913

Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
Approve the PR to run the CI check.

packages/harvester/harvester-cloud-provider/generated-changes/patch/Chart.yaml.patch

packages/rancher-monitoring/rancher-project-monitoring/generated-changes/patch/Chart.yaml.patch

packages/epinio/epinio/generated-changes/patch/Chart.yaml.patch

lucasmlp

LGTM 🚀

lucasmlp

LGTM 🚀

github-actions · 2024-06-05T23:05:27Z

Validation steps

Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.

  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913

Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
Approve the PR to run the CI check.

github-actions · 2024-06-05T23:08:38Z

Validation steps

Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.

  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913

Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
Approve the PR to run the CI check.

…neck

…e this fix after the release

github-actions · 2024-06-05T23:13:28Z

Validation steps

Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.

  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913

Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
Approve the PR to run the CI check.

mgfritch

sriov chart looks good, thanks!

github-actions · 2024-06-05T23:40:01Z

Validation steps

Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.

  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913

Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
Approve the PR to run the CI check.

github-actions · 2024-06-05T23:45:21Z

Validation steps

Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.

  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913

Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
Approve the PR to run the CI check.

github-actions · 2024-06-05T23:46:09Z

Validation steps

Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.

  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913

Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
Approve the PR to run the CI check.

github-actions · 2024-06-06T00:00:39Z

Validation steps

Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.

  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913

Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
Approve the PR to run the CI check.

github-actions · 2024-06-06T00:07:05Z

Validation steps

Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.

  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913

Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
Approve the PR to run the CI check.

nicholasSUSE · 2024-06-06T00:11:52Z

release.yaml

@@ -1,8 +1,18 @@
+rancher-istio:


These versions of rancher-istio and fleet should not be released on the future.
They are just for fixing the patching issues.

andreas-kupries

lgtm

…pts (#4014) I am using admin privileges to merge this to unblock the release process of release-v2.7.14. The fleet team is aware of the situation and they had previously approved it but I needed to make extra changes later. Regarding epinio, there was no release of a new chart, only the packages folder so I am bypassing it as well since I could not get a response in time.

nicholasSUSE requested review from a team as code owners June 4, 2024 19:11

nicholasSUSE requested a review from a team as a code owner June 4, 2024 19:32

w13915984028 approved these changes Jun 4, 2024

View reviewed changes

nicholasSUSE requested a review from andreas-kupries as a code owner June 4, 2024 19:44

nicholasSUSE changed the title ~~Fix patch failures 2.7~~ [dev-v2.7] Fix patch failures for newer versions of charts-build-scripts Jun 4, 2024

nicholasSUSE force-pushed the fix-patch-failures-2.7 branch from 9eaa8d2 to 25fa288 Compare June 4, 2024 20:02

lucasmlp requested changes Jun 4, 2024

View reviewed changes

joshmeranda approved these changes Jun 4, 2024

View reviewed changes

nicholasSUSE mentioned this pull request Jun 4, 2024

[dev-v2.7] Unrc monitoring 2.7 #3992

Closed

lucasmlp requested changes Jun 4, 2024

View reviewed changes

lucasmlp approved these changes Jun 4, 2024

View reviewed changes

nicholasSUSE requested a review from a team June 4, 2024 20:49

thardeck approved these changes Jun 5, 2024

View reviewed changes

nicholasSUSE force-pushed the fix-patch-failures-2.7 branch from af438b1 to 6b6d735 Compare June 5, 2024 23:08

nicholasSUSE added 3 commits June 5, 2024 20:10

bumping charts-build-scripts version to 0.5.3

40d154a

rancher-monitoring/rancher-monitoring - fixing make prepare

4bfd6a1

make charts rancher-monitoring/rancher-monitoring 102.0.5-rc1

7716a75

nicholasSUSE added 8 commits June 5, 2024 20:10

rancher-sriov - fixing make prepare

dc26946

rancher-alerting/rancher-alerting-drivers - make charts fixing bottle…

1c46483

…neck

rancher-monitoring/prometheus-federator - make charts fix bottleneck

8ca3686

harvester/harvester-cloud-provider - make prepare fix

711213b

rancher-monitoring/rancher-project-monitoring - make prepare fix

a65cd0f

epinio/epinio - make prepare fix

5f952ce

rancher-istio/rancher-istio marking as do not release, diogo will mak…

c83cb07

…e this fix after the release

rancher-alerting-drivers adding to the release.yaml

11edfe4

nicholasSUSE force-pushed the fix-patch-failures-2.7 branch from 6b6d735 to 11edfe4 Compare June 5, 2024 23:13

mgfritch approved these changes Jun 5, 2024

View reviewed changes

removing fleet from release.yaml, it was already released

227dbcc

nicholasSUSE force-pushed the fix-patch-failures-2.7 branch from 019a912 to 23ffe52 Compare June 5, 2024 23:45

nicholasSUSE force-pushed the fix-patch-failures-2.7 branch from 23ffe52 to fe5d2d7 Compare June 5, 2024 23:46

nicholasSUSE force-pushed the fix-patch-failures-2.7 branch from fe5d2d7 to 827ce7a Compare June 6, 2024 00:00

fleet/fleet - make charts to save the fix in 2.7

df56548

nicholasSUSE force-pushed the fix-patch-failures-2.7 branch from 827ce7a to df56548 Compare June 6, 2024 00:06

nicholasSUSE commented Jun 6, 2024

View reviewed changes

nicholasSUSE merged commit c7a959e into rancher:dev-v2.7 Jun 6, 2024
6 checks passed

nicholasSUSE mentioned this pull request Jun 6, 2024

[dev-v2.7] Unrc rancher-monitoring 102.0.5+up40.1.2 to be released at 2.7.14 #4024

Merged

thardeck mentioned this pull request Jun 6, 2024

[release/v2.7] fleet 102.2.6+up0.8.5 update rancher/rancher#45697

Merged

andreas-kupries reviewed Jun 6, 2024

View reviewed changes

nicholasSUSE mentioned this pull request Jun 6, 2024

[release-v2.7] 2nd batch releasing for 2.7.14 #4027

Merged

6 tasks

nicholasSUSE deleted the fix-patch-failures-2.7 branch June 10, 2024 22:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[dev-v2.7] Fix patch failures for newer versions of charts-build-scripts #4014

[dev-v2.7] Fix patch failures for newer versions of charts-build-scripts #4014

nicholasSUSE commented Jun 4, 2024 •

edited

Loading

github-actions bot commented Jun 4, 2024

github-actions bot commented Jun 4, 2024

github-actions bot commented Jun 4, 2024

github-actions bot commented Jun 4, 2024

github-actions bot commented Jun 4, 2024

w13915984028 left a comment

github-actions bot commented Jun 4, 2024

github-actions bot commented Jun 4, 2024

github-actions bot commented Jun 4, 2024

github-actions bot commented Jun 4, 2024

lucasmlp left a comment

lucasmlp left a comment

github-actions bot commented Jun 5, 2024

github-actions bot commented Jun 5, 2024

github-actions bot commented Jun 5, 2024

mgfritch left a comment

github-actions bot commented Jun 5, 2024

github-actions bot commented Jun 5, 2024

github-actions bot commented Jun 5, 2024

github-actions bot commented Jun 6, 2024

github-actions bot commented Jun 6, 2024

nicholasSUSE Jun 6, 2024

andreas-kupries left a comment

[dev-v2.7] Fix patch failures for newer versions of charts-build-scripts #4014

[dev-v2.7] Fix patch failures for newer versions of charts-build-scripts #4014

Conversation

nicholasSUSE commented Jun 4, 2024 • edited Loading

Problem

Solution

github-actions bot commented Jun 4, 2024

Validation steps

github-actions bot commented Jun 4, 2024

Validation steps

github-actions bot commented Jun 4, 2024

Validation steps

github-actions bot commented Jun 4, 2024

Validation steps

github-actions bot commented Jun 4, 2024

Validation steps

w13915984028 left a comment

Choose a reason for hiding this comment

github-actions bot commented Jun 4, 2024

Validation steps

github-actions bot commented Jun 4, 2024

Validation steps

github-actions bot commented Jun 4, 2024

Validation steps

github-actions bot commented Jun 4, 2024

Validation steps

lucasmlp left a comment

Choose a reason for hiding this comment

lucasmlp left a comment

Choose a reason for hiding this comment

github-actions bot commented Jun 5, 2024

Validation steps

github-actions bot commented Jun 5, 2024

Validation steps

github-actions bot commented Jun 5, 2024

Validation steps

mgfritch left a comment

Choose a reason for hiding this comment

github-actions bot commented Jun 5, 2024

Validation steps

github-actions bot commented Jun 5, 2024

Validation steps

github-actions bot commented Jun 5, 2024

Validation steps

github-actions bot commented Jun 6, 2024

Validation steps

github-actions bot commented Jun 6, 2024

Validation steps

nicholasSUSE Jun 6, 2024

Choose a reason for hiding this comment

andreas-kupries left a comment

Choose a reason for hiding this comment

nicholasSUSE commented Jun 4, 2024 •

edited

Loading