Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev-v2.9] Update scripts/pull-scripts to use new release scheme #4032

Merged

Conversation

adamkpickering
Copy link
Contributor

@adamkpickering adamkpickering commented Jun 6, 2024

In rancher/charts-build-scripts#128 we simplified the tooling for charts-build-scripts. Part of this involved improving the naming format of the binaries uploaded to charts-build-scripts releases. This necessitates an update to scripts/pull-scripts in this repo, since this script expects names of the old format.

This PR contains that update. I will need to make other PRs to update scripts/pull-scripts on other branches in addition to this one (dev-v2.7, dev-v2.8, release-v2.7, release-v2.8, and release-v2.9). I will link those PRs here.

@adamkpickering adamkpickering marked this pull request as ready for review June 10, 2024 21:40
@adamkpickering adamkpickering requested a review from a team as a code owner June 10, 2024 21:40
Copy link
Collaborator

@nicholasSUSE nicholasSUSE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants