Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v2.9] UnRC webhook v0.5.2 #4463

Merged
merged 3 commits into from
Sep 18, 2024
Merged

[v2.9] UnRC webhook v0.5.2 #4463

merged 3 commits into from
Sep 18, 2024

Conversation

nflynt
Copy link
Contributor

@nflynt nflynt commented Sep 18, 2024

@nflynt nflynt requested a review from a team as a code owner September 18, 2024 12:21
@github-actions GitHub Actions
Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

nicholasSUSE
nicholasSUSE approved these changes Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@nicholasSUSE nicholasSUSE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicholasSUSE nicholasSUSE merged commit 31d3694 into rancher:dev-v2.9 Sep 18, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomleb tomleb tomleb approved these changes

@nicholasSUSE nicholasSUSE nicholasSUSE approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nflynt @tomleb @nicholasSUSE