Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev-v2.10] rancher-backup support k8s 1.31 #4477

Merged
merged 3 commits into from
Sep 24, 2024

Conversation

jbiers
Copy link
Member

@jbiers jbiers commented Sep 23, 2024

@jbiers jbiers requested a review from a team as a code owner September 23, 2024 16:26
Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@mallardduck
Copy link
Member

mallardduck commented Sep 23, 2024

@jbiers - Looks good overall, however I think this should technically be pulling from head/main and use a 6.x BRO upstream version. So we may just need to create a 6.0.0-rc.1 first in BRO, then point this PR at that as the source.

Have CI running to create now: https://github.com/rancher/backup-restore-operator/actions/runs/10999264305
https://github.com/rancher/backup-restore-operator/releases/tag/v6.0.0-rc.1

@jbiers jbiers force-pushed the rancher-backup-support-k8s-1.31 branch from 363908b to aa7f1ff Compare September 24, 2024 19:49
Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

Copy link
Member

@mallardduck mallardduck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT. Was able to upgrade from 2.9 version of BRO to 2.10 rc fine.

@jbiers jbiers merged commit 7dcf366 into rancher:dev-v2.10 Sep 24, 2024
6 checks passed
@jbiers jbiers deleted the rancher-backup-support-k8s-1.31 branch September 24, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants