Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v2.9] oob neuvector 104.0.2+up2.8.0 release #4494

Merged
merged 4 commits into from
Sep 26, 2024

Conversation

tashima42
Copy link
Collaborator

@tashima42 tashima42 commented Sep 26, 2024

Charts Checklist (built for v0.9.X charts-build-scripts)

Checkpoint 0: Validate release.yaml

Validation steps:

  • Each chart version in release.yaml DOES NOT modify an already released chart. If so, stop and modify the versions so that it releases a net-new chart.
  • Each chart version in release.yaml IS exactly 1 more patch version than the last released chart version. If not, stop and modify the versions so that it releases a net-new chart.

Checkpoint 1: Compare contents of assets/ to charts/

Validation steps:

  • Running make unzip to regenerate the charts/ from scratch, then git diff to check differences between assets/ and charts/ yields NO differences or innocuous differences.

IMPORTANT: Do not undo these changes for future steps since we want to keep the charts/ that match the current contents of assets!

Checkpoint 2: Compare assets against index.yaml

Validation steps:

  • The index.yaml file has an entry for each chart version.
  • The index.yaml entries for each chart matches the Chart.yaml for each chart.
  • Each chart has ALL required annotations
  • kube-version annotation
  • rancher-version annotation
  • permits-os annotation (indicates Windows and/or Linux)

Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@tashima42 tashima42 changed the title [release-v2.9] batch release [release-v2.9] oob neuvector 104.0.2+up2.8.0 release Sep 26, 2024
@tashima42 tashima42 requested a review from a team September 26, 2024 19:24
@nicholasSUSE nicholasSUSE added the regsync-ready PR ready to sync images with prime registry label Sep 26, 2024
Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@tashima42 tashima42 merged commit 1d0b69f into release-v2.9 Sep 26, 2024
5 checks passed
@tashima42 tashima42 deleted the oob-neuvector-v2.9.3 branch September 26, 2024 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regsync-ready PR ready to sync images with prime registry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants