Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump http-proxy-middleware from 2.0.6 to 2.0.7 #12341

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 23, 2024

Bumps http-proxy-middleware from 2.0.6 to 2.0.7.

Release notes

Sourced from http-proxy-middleware's releases.

v2.0.7

Full Changelog: chimurai/http-proxy-middleware@v2.0.6...v2.0.7

v2.0.7-beta.1

Full Changelog: chimurai/http-proxy-middleware@v2.0.7-beta.0...v2.0.7-beta.1

v2.0.7-beta.0

Full Changelog: chimurai/http-proxy-middleware@v2.0.6...v2.0.7-beta.0

Changelog

Sourced from http-proxy-middleware's changelog.

v2.0.7

  • ci(github actions): add publish.yml
  • fix(filter): handle errors
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Oct 23, 2024
@rak-phillip rak-phillip self-assigned this Oct 25, 2024
@rak-phillip rak-phillip added this to the v2.11.0 milestone Nov 5, 2024
@rak-phillip
Copy link
Member

This one might be easier to review commit-by-commit. I removed @nuxtjs/axios from shell because it was pulling in http-proxy-middleware@1.3.1.

We shouldn't be reliant on any nuxt dependencies at this point, so this dependency should be safe to remove, but it's best to validate that this is the case.

@aalves08
Copy link
Member

aalves08 commented Nov 6, 2024

I'll need some time to test this @rak-phillip 🙏 Not sure if I'll reply today or tomorrow

@rak-phillip
Copy link
Member

Take your time. There's some CI failures that I need to investigate before really committing to this change.

@rak-phillip
Copy link
Member

rak-phillip commented Nov 6, 2024

The removal of @nuxt/axios demands that we also add axios, axios-retry, and defu as dependencies to shell. I think that this is an improvement overall because shell dependencies are now more in line with root-level dependencies.

edit: and we're able to eliminate the http-proxy-middleware@1.3.1 dependency that @nuxt/axios was bringing into shell. Now we have a single version that is consistent across both Dashboard and Shell.

dependabot bot and others added 4 commits November 14, 2024 14:42
Bumps [http-proxy-middleware](https://github.com/chimurai/http-proxy-middleware) from 2.0.6 to 2.0.7.
- [Release notes](https://github.com/chimurai/http-proxy-middleware/releases)
- [Changelog](https://github.com/chimurai/http-proxy-middleware/blob/v2.0.7/CHANGELOG.md)
- [Commits](chimurai/http-proxy-middleware@v2.0.6...v2.0.7)

---
updated-dependencies:
- dependency-name: http-proxy-middleware
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
- `http-proxy-middleware@1.3.1` is a transitive dependency of `@nuxtjs/axios`
- `@nuxtjs/axios` isn't used anywhere throughout shell, so it can be safely removed at this point

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
@jordojordo jordojordo force-pushed the dependabot/npm_and_yarn/http-proxy-middleware-2.0.7 branch from e5b999c to ddfb3ec Compare November 14, 2024 19:43
@jordojordo
Copy link
Member

I have tested this manually by publishing shell to a local server and building the Kubewarden UI Extension using these updates. No issues were noted.

I've rebased which will reapply the checks for our extensions (Kubewarden, Elemental, and NeuVector) within the check-plugins-build workflow. If this and the rest of the checks pass these changes should be fine.

@jordojordo jordojordo merged commit 58808d7 into master Nov 14, 2024
31 checks passed
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/http-proxy-middleware-2.0.7 branch November 14, 2024 20:14
@aalves08
Copy link
Member

Thanks for the review @jordojordo . This was on my todo list... With the re-enable of the extension checks in the test-plugins-build I think we can "automate" these PRs, because every time we wanted to do a dependency change we would have to do all that setup, it would be crazy... My system does not play well with verdaccio 😛

@jordojordo
Copy link
Member

No problem, verdaccio is temperamental on my machine, but it worked in this case 🧙‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants