Fleet Performance Improvements #12413
Conversation
| const perEntry = r.perClusterState?.find((x) => x.clusterId === c.id); | ||
| const tooMany = r.perClusterState?.length >= 10 || false; | ||
| const tooMany = r.perClusterState?.length >= 10 || false; // FIXME: shouldn't we not calc perEntry if there are too many? |
There was a problem hiding this comment.
Additionally, in the current implementation Fleet creates an incomplete flag on the resource and shouldn't add more than 10 perCluster states.
| @@ -323,14 +324,18 @@ export default class GitRepo extends SteveModel { | |||
| get resourcesStatuses() { | |||
| const clusters = this.targetClusters || []; | |||
| const resources = this.status?.resources || []; | |||
| const conditions = this.status?.conditions || []; | |||
| // const conditions = this.status?.conditions || []; | |||
| // const bundleDeployments = this.bundleDeployments || []; | |||
|
|
|||
| const out = []; | |||
|
|
|||
| for (const c of clusters) { | |||
There was a problem hiding this comment.
This code assumes each resource is installed on every cluster. This is not always the case. Users can for example use targetCustomization to deploy resources only to some clusters. Additionally, popular charts install different resources depending on the k8s version of the cluster. Some charts even allow to deploy "extraObjects" via a helm chart value. 🤷
There was a problem hiding this comment.
Regarding get targetClusters() { that can be overriden via fleet.yaml so this code can't really deduct the targeted clusters anymore.
There was a problem hiding this comment.
ouch, as in the gitrepo resource has a native targetClusters property?
|
superseded by #12521 |
Summary
Contributes to #12424
Occurred changes and/or fixed issues
Technical notes summary
Areas or cases that should be tested
Areas which could experience regressions
Screenshot/Video
Checklist