Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clusters: Unable to edit local cluster #12506

Closed
yonasberhe23 opened this issue Nov 5, 2024 · 5 comments · Fixed by #12583
Closed

Clusters: Unable to edit local cluster #12506

yonasberhe23 opened this issue Nov 5, 2024 · 5 comments · Fixed by #12583
Assignees
Labels
kind/bug QA/manual-test Indicates issue requires manually testing status/backport-candidate
Milestone

Comments

@yonasberhe23
Copy link
Contributor

yonasberhe23 commented Nov 5, 2024

Setup

  • Rancher version: v2.10-e59c50a79bff2b6cc023bdbdb4e825190b7833fb-head
  • Rancher UI: master f878279
  • Browser type & version: Chrome

Describe the bug
User is unable to edit local cluster.

To Reproduce

  1. go to cluster management
  2. click ellipsis for local cluster
  3. click Edit Config
  4. notice Create button (should be Save) is disabled
  5. add description
  6. notice Create button is still disabled

Result
User is unable to edit local cluster.

Expected Result
User is able to edit local cluster.

Screenshots

Screen.Recording.2024-11-05.at.12.30.37.PM.mov

Additional context

@yonasberhe23 yonasberhe23 added this to the v2.11.0 milestone Nov 5, 2024
@github-actions github-actions bot added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label Nov 5, 2024
@mantis-toboggan-md mantis-toboggan-md self-assigned this Nov 5, 2024
@mantis-toboggan-md mantis-toboggan-md added QA/manual-test Indicates issue requires manually testing status/backport-candidate and removed QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this labels Nov 5, 2024
@gaktive
Copy link
Member

gaktive commented Nov 6, 2024

Problem not happening on RKE2 & k3s. QA to confirm if this is happening elsewhere; if this is only local, then it's a release note for 2.10.0 until we figure out what to do since code change here will touch a lot of things.

@mantis-toboggan-md
Copy link
Member

mantis-toboggan-md commented Nov 6, 2024

Looks related to this getter. When touching this code there is a possiblity for regression in the provider/distro column of cluster list views, as well as routing to/from the 'edit config' of clusters generally. We'll need to verify list and 'edit config' behavior for each of the following cluster types:

local clusters:

  • rke1
  • rke2
  • k3s
  • hosted

downstream clusters:

  • ke1 provisioned
  • rke2 provisioned
  • k3s provisioned
  • rke1 imported
  • rke2 imported
  • k3s imported
  • hosted imported

@gaktive
Copy link
Member

gaktive commented Nov 8, 2024

/backport v2.10.0

@mantis-toboggan-md
Copy link
Member

/backport v2.9.5

@yonasberhe23
Copy link
Contributor Author

Closing this out as I have already tested this in 2.10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment