-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve vGPU allocation #11399
base: master
Are you sure you want to change the base?
Improve vGPU allocation #11399
Conversation
2376d70
to
d815091
Compare
We need a deployment with |
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
d815091
to
c8b07d8
Compare
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
c8b07d8
to
9ea14af
Compare
the vGPU dropdown should only show name of vGPU Type, and not individual vGPU name as well. for example, the cluster in question has the following vgpu devices configured
the UI screenshot seems to be including Ideally we should only use the names reported from the new api. In this case the drop down should show
|
Thanks for helping us clarify the test result. So if each vGPU type allocatable number > 0 , we would show below as option name
|
Is it in conflict with vGPU modeling we have on Harvester -> vGPU devices table ? The key for vGPU elements in that table is In fact, the vGPU
Is there something I'm missing ? |
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
c5aa986
to
965287d
Compare
I've updated the PR description with the some notes about removing the profile from the label. Please take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need change to handle legacy harvester scenario
Just pushed the changes to support legacy Harvester versions and re-enable validations steps. |
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
1328c7b
to
578e44d
Compare
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
7d8d4d4
to
1c93eb7
Compare
As I understand through comments including @nwmac once we finalize this, we should backport this to 2.9.next2 (as of writing, which will go up to next1 once we rename versions). Harvester will also do a release note. |
Along with 2.9.x, we should backport to 2.8.x. |
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
@a110605 this is now updated to support harvester#1154 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing locally with harvester#1154.
The assigned vGPU is correct in rancher cluster page edit & view pages.
Summary
Related issue harvester/harvester#5774
Blocked by harvester#1154
Blocked by harvester/pcidevices#91
Occurred changes and/or fixed issues
Technical notes summary
Improve tracking of device allocation harvester/harvester#6096 introduced the new
/v1/harvester/cluster
endpoint to provide available Harvester resources; we are now using those information to get the allocatable number for each vGpu device.Fixing the vGpu validation; We are now counting the
nodePools
xmachineCount
to check if there are enough vGpu devices to be assigned to each machine.In legacy Harvester versions -
/v1/harvester/cluster
endpoint is not available and the UI will not be able to calculate theallocatable
label. We will leave it empty - see screenshots- and add some notes in the documentations to inform the users to upgrade their Harvester 1.3.x to 1.3.2.965287d - Based on offline discussion with @a110605 and @ibrokethecloud we are removing the vGpu
profile
id from option labels, since it is meaningless from users perspective.key
in the 'vGPUs' dropdown element is now the vGpu type.How to tests
Create a new Harvester cluster
Create another Harvester Cluster
allocatable
number - the backend should update this number after cluster creation.Edit a Harvester Cluster
allocatable
number - the backend should update this number after saving.Create multiple nodes Clusters
Areas or cases that should be tested
Harvester clusters, create/edit page.
Areas which could experience regressions
Screenshot/Video
Harvester 1.3.2
Harvester legacy versions
Validation
Checklist