Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v0.12] Fleet job pods do not receive tolerations from values.yaml #3280

Open
weyfonk opened this issue Jan 30, 2025 · 1 comment
Open

[v0.12] Fleet job pods do not receive tolerations from values.yaml #3280

weyfonk opened this issue Jan 30, 2025 · 1 comment
Labels
Milestone

Comments

@weyfonk
Copy link
Contributor

weyfonk commented Jan 30, 2025

Forward-port of #3180 to v0.12.

@weyfonk weyfonk self-assigned this Jan 30, 2025
@rancherbot rancherbot added this to Fleet Jan 30, 2025
@github-project-automation github-project-automation bot moved this to 🆕 New in Fleet Jan 30, 2025
@weyfonk weyfonk added this to the v2.11.0 milestone Jan 30, 2025
@weyfonk weyfonk moved this from 🆕 New to 🏗 In progress in Fleet Jan 30, 2025
@weyfonk weyfonk moved this from 🏗 In progress to 👀 In review in Fleet Jan 30, 2025
@weyfonk
Copy link
Contributor Author

weyfonk commented Jan 31, 2025

Additional QA

Problem

Installing Fleet charts in a cluster where all nodes are tainted would fail, because Fleet jobs did not support node tolerations coming from chart values. This would result in Fleet failing to install.
Affected jobs were the cleanup jobs for cluster registrations and completed jobs.

Solution

The Fleet chart now propagates node tolerations from chart values to those jobs, as it does for other deployed pods.

Testing

Engineering Testing

Manual Testing

This has been tested by tainting one node in a k3d cluster, and checking that:

  • deployment was successful
  • jobs were not scheduled on the tainted node, unless the corresponding toleration was set in chart values

Automated Testing

N/A

QA Testing Considerations

It would make sense to test this in a cluster where all nodes are tainted:

  • if no tolerations are specified in chart values, running the above mentioned jobs should still fail
  • setting tolerations matching at least one node's taints should enable successful deployment, with both jobs being created and run successfully.

Regressions Considerations

N/A

@weyfonk weyfonk moved this from 👀 In review to Needs QA review in Fleet Jan 31, 2025
@weyfonk weyfonk removed their assignment Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Needs QA review
Development

No branches or pull requests

1 participant