From 3623d55af9b3517d1f7f7a06dcc74f38cd073c25 Mon Sep 17 00:00:00 2001 From: Jack Yu Date: Fri, 12 Jul 2024 15:57:20 +0800 Subject: [PATCH] comment: about optional phases Signed-off-by: Jack Yu --- pkg/manager/manager.go | 1 + 1 file changed, 1 insertion(+) diff --git a/pkg/manager/manager.go b/pkg/manager/manager.go index e848f796..faa1026d 100644 --- a/pkg/manager/manager.go +++ b/pkg/manager/manager.go @@ -169,6 +169,7 @@ func (m *SupportBundleManager) runAllPhases(requiredPhases []RunPhase, optionalP for _, phase := range optionalPhases { if err := m.runPhase(phase, &progressCount, maxProgressCount); err != nil { logrus.Errorf("Failed to run optionalPhases %s: %s", phase.Name, err.Error()) + // Since it's optional, don't return error. continue } }