From 5281830e17ac0783c3df3d1fafc10d32c667fe6d Mon Sep 17 00:00:00 2001 From: Gaurav Mehta Date: Wed, 22 May 2024 11:38:22 +1000 Subject: [PATCH] log error details when error is encountered during bundle collection --- pkg/manager/cluster.go | 2 +- pkg/manager/collectors/cluster.go | 2 +- pkg/manager/collectors/default.go | 2 +- pkg/manager/collectors/harvester.go | 4 ++-- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/pkg/manager/cluster.go b/pkg/manager/cluster.go index 80e2ee1d..b8a6d1f7 100644 --- a/pkg/manager/cluster.go +++ b/pkg/manager/cluster.go @@ -59,7 +59,7 @@ func (c *Cluster) GenerateClusterBundle(bundleDir string) (string, error) { errLog, err := os.Create(filepath.Join(bundleDir, "bundleGenerationError.log")) if err != nil { - logrus.Errorf("Failed to create bundle generation log") + logrus.Errorf("Failed to create bundle generation log: %v", err) return "", err } defer errLog.Close() diff --git a/pkg/manager/collectors/cluster.go b/pkg/manager/collectors/cluster.go index a52c4b80..d92c67d3 100644 --- a/pkg/manager/collectors/cluster.go +++ b/pkg/manager/collectors/cluster.go @@ -26,7 +26,7 @@ func (module clusterModule) generateYAMLs() { objs, err := module.c.discovery.ResourcesForCluster(module.toObj, module.c.exclude, module.c.errorLog) if err != nil { - logrus.Error("Unable to fetch cluster resources") + logrus.Errorf("Unable to fetch cluster resources: %v", err) return } diff --git a/pkg/manager/collectors/default.go b/pkg/manager/collectors/default.go index f067bcf4..7314ae9f 100644 --- a/pkg/manager/collectors/default.go +++ b/pkg/manager/collectors/default.go @@ -56,7 +56,7 @@ func (module defaultModule) generateDiscoveredNamespacedYAMLs(namespace string, objs, err := module.c.discovery.ResourcesForNamespace(module.toObj, namespace, module.c.exclude, errLog) if err != nil { - logrus.Error("Unable to fetch namespaced resources") + logrus.Errorf("Unable to fetch namespaced resources: %v", err) return } diff --git a/pkg/manager/collectors/harvester.go b/pkg/manager/collectors/harvester.go index 0cea517c..f526e92d 100644 --- a/pkg/manager/collectors/harvester.go +++ b/pkg/manager/collectors/harvester.go @@ -33,7 +33,7 @@ func (module harvesterModule) generateYAMLs() { objs, err := module.c.discovery.SpecificResourcesForNamespace(module.toObj, module.name, namespace, resourceLists, module.c.errorLog) if err != nil { - logrus.Error("Unable to fetch namespaced resources") + logrus.Errorf("Unable to fetch namespaced resources: %v", err) return } @@ -48,7 +48,7 @@ func (module harvesterModule) generateYAMLs() { objs, err := module.c.discovery.ResourcesForCluster(module.toClusterObj, module.skipClusterObjects, module.c.errorLog) if err != nil { - logrus.Error("Unable to fetch cluster scoped resources") + logrus.Errorf("Unable to fetch cluster scoped resources: %v", err) return }