ci: fix arm64

.github/workflows/template-build.yml

@@ -14,38 +14,18 @@ jobs:
     permissions:
       contents: read
       id-token: write
-    container:
-      image: rancher/dapper:v0.5.8
-    strategy:
-      fail-fast: false
-      matrix:
-        platform:
-          - linux/amd64
-          - linux/arm64
     steps:
-      # Git is not in Dapper container image. Add it manually for dirty check.
-      - name: Add Git
-        run: apk add -U git
-
       - name: Checkout code
         uses: actions/checkout@v4
 
-      - name: Get Arch
-        id: get-arch
-        run: |
-          arch=$(echo ${{ matrix.platform }} | cut -c 7-)
-          echo "ARCH=$arch" >> "$GITHUB_OUTPUT"
-
-
-
       - name: Set up QEMU
         uses: docker/setup-qemu-action@v3
 
       - name: Set up Docker Buildx
         uses: docker/setup-buildx-action@v3
 
       - name: Run dapper
-        run: dapper ci
+        run: make ci
 
       - name: Read some Secrets
         uses: rancher-eio/read-vault-secrets@main
@@ -67,43 +47,9 @@ jobs:
         with:
           provenance: false
           context: .
-          platforms: ${{ matrix.platform }}
+          platforms: linux/amd64,linux/arm64
           file: package/Dockerfile
           push: ${{ inputs.push }}
-          tags: rancher/support-bundle-kit:${{ inputs.release-tag-name }}-${{ steps.get-arch.outputs.ARCH }}
+          tags: rancher/support-bundle-kit:${{ inputs.release-tag-name }}
           build-args: |
-            ARCH=${{ steps.get-arch.outputs.ARCH }}
-            VERSION=${{ github.ref_name }}-${{ github.sha }}-head
-
-  manifest:
-    if: ${{ inputs.push == true }}
-    runs-on: ubuntu-latest
-    permissions:
-      contents: read
-      id-token: write
-    needs:
-      - dapper-build
-    steps:
-      - name: Checkout code
-        uses: actions/checkout@v2
-
-      - name: Read some Secrets
-        uses: rancher-eio/read-vault-secrets@main
-        with:
-          secrets: |
-            secret/data/github/repo/${{ github.repository }}/dockerhub/rancher/credentials username | DOCKER_USERNAME ;
-            secret/data/github/repo/${{ github.repository }}/dockerhub/rancher/credentials password | DOCKER_PASSWORD
-
-      - name: Login to Docker Hub
-        uses: docker/login-action@v2
-        with:
-          username: ${{ env.DOCKER_USERNAME }}
-          password: ${{ env.DOCKER_PASSWORD }}
-
-      - name: Create Manifest arm64 and amd64
-        run: >
-          docker manifest create rancher/support-bundle-kit:${{ inputs.release-tag-name }} rancher/support-bundle-kit:${{ inputs.release-tag-name }}-amd64 rancher/support-bundle-kit:${{ inputs.release-tag-name }}-arm64
-        working-directory: package
-
-      - name: Push Manifest
-        run: docker manifest push rancher/support-bundle-kit:${{ inputs.release-tag-name }}
+            VERSION=${{ github.ref_name }}-${{ github.sha }}-head

Dockerfile.dapper

@@ -10,10 +10,15 @@ RUN zypper -n install ca-certificates awk lsb-release rsync docker containerd
 ## install golangci
 RUN curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b "$(go env GOPATH)/bin" v1.55.2;
 
+# The docker version in dapper is too old to have buildx. Install it manually.
+RUN curl -sSfL https://github.com/docker/buildx/releases/download/v0.13.1/buildx-v0.13.1.linux-${ARCH} -o buildx-v0.13.1.linux-${ARCH} && \
+    chmod +x buildx-v0.13.1.linux-${ARCH} && \
+    mv buildx-v0.13.1.linux-${ARCH} /usr/local/bin/buildx
+
 # -- for dapper
 ENV DAPPER_RUN_ARGS --privileged --network host -v /run/containerd/containerd.sock:/run/containerd/containerd.sock
 ENV GO111MODULE off
-ENV DAPPER_ENV REPO TAG DRONE_TAG CROSS GOPROXY
+ENV DAPPER_ENV REPO TAG DRONE_TAG
 ENV DAPPER_DOCKER_SOCKET true
 ENV DAPPER_SOURCE /go/src/github.com/rancher/support-bundle-kit/
 ENV DAPPER_OUTPUT ./bin ./dist

package/Dockerfile

@@ -1,10 +1,16 @@
 FROM registry.suse.com/bci/bci-base:15.5
 
+ARG TARGETPLATFORM
+RUN if [ "$TARGETPLATFORM" != "linux/amd64" ] && [ "$TARGETPLATFORM" != "linux/arm64" ]; then \
+    echo "Error: Unsupported TARGETPLATFORM: $TARGETPLATFORM" && \
+    exit 1; \
+    fi
+
 RUN zypper -n rm container-suseconnect && \
     zypper -n install zip curl which tar && \
     zypper -n clean -a && rm -rf /tmp/* /var/tmp/* /usr/share/doc/packages/*
 
-ARG ARCH=amd64
+ENV ARCH=${TARGETPLATFORM#linux/}
 ENV TINI_VERSION v0.19.0
 ENV TINI_URL_amd64=https://github.com/krallin/tini/releases/download/${TINI_VERSION}/tini \
     TINI_URL_arm64=https://github.com/krallin/tini/releases/download/${TINI_VERSION}/tini-arm64 \
@@ -20,7 +26,7 @@ RUN chmod +x /usr/bin/entrypoint.sh
 ADD hack/support-bundle-collector.sh /usr/bin
 RUN chmod +x /usr/bin/support-bundle-collector.sh
 
-ADD bin/support-bundle-kit /usr/bin
+ADD bin/support-bundle-kit-${ARCH} /usr/bin/support-bundle-kit
 RUN chmod +x /usr/bin/support-bundle-kit
 
 ADD hack/collector-* /usr/bin/

scripts/build

@@ -10,11 +10,9 @@ fi
 
 LINKFLAGS="-X github.com/rancher/support-bundle-kit/cmd.AppVersion=$VERSION
            -X github.com/rancher/support-bundle-kit/cmd.GitCommit=$COMMIT"
-CGO_ENABLED=0 go build -ldflags "$LINKFLAGS $OTHER_LINKFLAGS" -o bin/support-bundle-kit
-if [ "$CROSS" = "true" ] && [ "$ARCH" = "amd64" ]; then
-    GOOS=darwin go build -ldflags "$LINKFLAGS" -o bin/support-bundle-kit-darwin
-    GOOS=windows go build -ldflags "$LINKFLAGS" -o bin/support-bundle-kit-windows
-fi
+
+CGO_ENABLED=0 GOARCH=amd64 go build -ldflags "$LINKFLAGS $OTHER_LINKFLAGS" -o bin/support-bundle-kit-amd64
+CGO_ENABLED=0 GOARCH=arm64 go build -ldflags "$LINKFLAGS $OTHER_LINKFLAGS" -o bin/support-bundle-kit-arm64
 
 # non-go scripts
 cp hack/* bin

scripts/package

@@ -7,24 +7,24 @@ cd $(dirname $0)/..
 
 mkdir -p dist/artifacts
 cp bin/* dist/artifacts
-mv dist/artifacts/support-bundle-kit dist/artifacts/support-bundle-kit${SUFFIX}
-
-case $(uname -m) in
-  aarch64 | arm64)
-    ARCH=arm64
-    ;;
-  x86_64)
-    ARCH=amd64
-    ;;
-  s390x)
-    ARCH=s390x
-    ;;
-  *)
-    echo "$(uname -a): unsupported architecture"
-    exit 1
-esac
 
 IMAGE=${REPO}/support-bundle-kit:${TAG}
+DOCKERFILE=package/Dockerfile
+
+docker run --privileged --rm tonistiigi/binfmt --install all
+buildx create --platform linux/amd64,linux/arm64 --use
+buildx ls
+
+# In old docker version, it doesn't support multiple values in --platform with --load.
+# So we only load image with current platform.
+# Ref: https://github.com/docker/buildx/issues/59#issuecomment-616050491
+
+# build
+buildx build --platform linux/amd64,linux/arm64 \
+  -f ${DOCKERFILE} -t ${IMAGE} .
+
+# test
+buildx build --load \
+  -f ${DOCKERFILE} -t ${IMAGE} .
 
-docker build --build-arg ARCH=${ARCH} --no-cache -f package/Dockerfile -t ${IMAGE} .
 echo Built ${IMAGE}

scripts/version

@@ -13,13 +13,8 @@ else
     VERSION="${COMMIT}${DIRTY}"
 fi
 
-if [ -z "$ARCH" ]; then
-    ARCH=$(go env GOHOSTARCH)
-fi
-
-SUFFIX="-${ARCH}"
 
-TAG=${TAG:-${VERSION}${SUFFIX}}
+TAG=${TAG:-${VERSION}}
 REPO=${REPO:-rancher}
 
 if echo $TAG | grep -q dirty; then