Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fleet addon provider doesn't have ProviderName set #630

Open
thehejik opened this issue Aug 1, 2024 · 3 comments
Open

Fleet addon provider doesn't have ProviderName set #630

thehejik opened this issue Aug 1, 2024 · 3 comments
Labels
kind/bug Something isn't working

Comments

@thehejik
Copy link

thehejik commented Aug 1, 2024

After installing Turtles Operator v0.10.0 with Seamless integration with Fleet and CAPI enabled (installs caapf v0.3.0) together with UI extension in Rancher v2.8 there is no ProviderName set for fleet addon in CAPI/Providers overview page. This field seems to be mandatory when adding a custom provider manually. It probably doesn't have any impact on functionality.

image

What did you expect to happen?

The ProviderName is set for eg. to fleet value.

How to reproduce it?

No response

Rancher Turtles version

No response

Anything else you would like to add?

No response

Label(s) to be applied

/kind bug

@thehejik thehejik added the kind/bug Something isn't working label Aug 1, 2024
@Danil-Grigorev
Copy link
Contributor

Unfortunately this is upstream table representation limitation. If it is not set, it means that the name is consistent with providerName internally. If there is a way to represent default for jsonPath, this issue is hard to fix.

@kkaempf kkaempf added this to the September release milestone Aug 13, 2024
@alexander-demicev
Copy link
Member

@Danil-Grigorev any chance we can introduce custom provider names if fetch config is provided?

@Danil-Grigorev
Copy link
Contributor

Not sure I understand the question.

Custom provider naming is possible now, and the table viewed in UI shows providers with custom name. It is determined based on spec.providerName being set or not. Missing spec.providerName uses metadata.name as a source for provider name internally.

The only provider wich has no custom name is the fleet addon provider. To address the display issue, I propose to change table representation to use a new status.providerName field, which will be populated by controller from either of the sources:

  • metadata.name
  • spec.providerName (has higher priority)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
Development

No branches or pull requests

4 participants