Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add new e2e test suite for v2prov #175

Merged
merged 2 commits into from
Oct 3, 2023

Conversation

richardcase
Copy link
Contributor

@richardcase richardcase commented Sep 29, 2023

What this PR does / why we need it:

This adds a new e2e test suite that will ensure that v2prov doesn't break with Rancher Turtles installed.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #106

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • adds or updates e2e tests

@richardcase richardcase added area/testing Indicates an issue related to test kind/feature labels Sep 29, 2023
@richardcase richardcase force-pushed the e2e_v2prov branch 3 times, most recently from d897ce1 to bca7a3b Compare October 3, 2023 05:04
@richardcase richardcase changed the title [WIP] Add new e2e test suite for v2prov test: Add new e2e test suite for v2prov Oct 3, 2023
@richardcase richardcase marked this pull request as ready for review October 3, 2023 05:05
@richardcase richardcase requested a review from a team as a code owner October 3, 2023 05:05
salasberryfin
salasberryfin previously approved these changes Oct 3, 2023
Copy link
Contributor

@Danil-Grigorev Danil-Grigorev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this e2e require additional variables in the nightly job?

This change adds a new e2e test suite that checks that installing
Rancher Turtles doesn't break v2prov.

The test will provision a RKE2 cluster in Azure. It will then connect to
the cluster via the kubeconfig.

Signed-off-by: Richard Case <richard.case@suse.com>
Danil-Grigorev
Danil-Grigorev previously approved these changes Oct 3, 2023
test/e2e/const.go Show resolved Hide resolved
furkatgofurov7
furkatgofurov7 previously approved these changes Oct 3, 2023
Copy link
Contributor

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Richard Case <richard.case@suse.com>
@richardcase richardcase merged commit 4e87c11 into rancher:main Oct 3, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Indicates an issue related to test kind/feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[e2e] Add test to ensure v2prov doesn't break
4 participants