Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable RKE2 tests for 0.6.0 version, after migration #634

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

Danil-Grigorev
Copy link
Contributor

@Danil-Grigorev Danil-Grigorev commented Aug 5, 2024

What this PR does / why we need it:

Released version 0.6.0 is not currently tested in rancher turtles.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@Danil-Grigorev Danil-Grigorev requested a review from a team as a code owner August 5, 2024 13:50
@salasberryfin
Copy link
Contributor

I think this was originally disabled because we moved back to CAPD v1.4.6 (aligned with core CAPI) which is missing some features required to be used together with CAPRKE2. I'm not sure we're able to enable these tests before moving to a newer CAPI version.

@Danil-Grigorev
Copy link
Contributor Author

It should be possible to bump CAPI to 1.7.0 within the test case itself. Thanks for pointing this out @salasberryfin!

furkatgofurov7
furkatgofurov7 previously approved these changes Aug 15, 2024
@Danil-Grigorev
Copy link
Contributor Author

For some reason the machine replica is not healthy as it is unable to find nodeRef.

  - lastTransitionTime: "2024-08-15T11:45:47Z"
    reason: WaitingForNodeRef
    severity: Info
    status: "False"
    type: NodeHealthy

@Danil-Grigorev
Copy link
Contributor Author

Core of the issue seems to be #664.

@Danil-Grigorev
Copy link
Contributor Author

This should be unblocked once #666 is merged

mjura
mjura previously approved these changes Aug 19, 2024
@Danil-Grigorev
Copy link
Contributor Author

Danil-Grigorev commented Aug 20, 2024

Tests are failing due to agent pods getting evicted on the RKE2 cluster:

  - lastHeartbeatTime: "2024-08-20T15:46:18Z"
    lastTransitionTime: "2024-08-20T15:44:05Z"
    message: kubelet has disk pressure
    reason: KubeletHasDiskPressure
    status: "True"
    type: DiskPressure

- Use hosted runner to avoid hitting disk pressure

Signed-off-by: Danil-Grigorev <danil.grigorev@suse.com>
@furkatgofurov7
Copy link
Contributor

furkatgofurov7 commented Aug 29, 2024

#696 is merged now, so retitling the PR and it's description.

@furkatgofurov7 furkatgofurov7 changed the title Re-enable RKE2 tests for 0.5.0 version, after migration Re-enable RKE2 tests for 0.6.0 version, after migration Aug 29, 2024
@Danil-Grigorev Danil-Grigorev merged commit fa89da1 into rancher:main Sep 2, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants