Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo fails ansible-lint #151

Closed
Daemonslayer2048 opened this issue Aug 25, 2023 · 3 comments · Fixed by #161
Closed

Repo fails ansible-lint #151

Daemonslayer2048 opened this issue Aug 25, 2023 · 3 comments · Fixed by #161
Assignees

Comments

@Daemonslayer2048
Copy link
Contributor

This repo is currently failing ansible-lint. That should probably be corrected, at the same time the collections should probably be updated to the FQCNs as described here: https://ansible.readthedocs.io/projects/lint/rules/fqcn/

We recommend you start using the fully-qualified collection name (FQCN) in your playbooks as the explicit and authoritative indicator of which collection to use as some collections may contain duplicate module names.

@Daemonslayer2048 Daemonslayer2048 self-assigned this Aug 25, 2023
@Daemonslayer2048
Copy link
Contributor Author

Upon further review in order to resolve var-naming[no-role-prefix] the three roles would need to be condensed into a single role. I think this is achievable but would require a much more lengthy discussion. I am going to create an MR to address the FQCN issue and a couple unrelated linting tasks.

@Daemonslayer2048 Daemonslayer2048 mentioned this issue Sep 27, 2023
4 tasks
@mddamato
Copy link
Contributor

Should be fixed in #155

@Daemonslayer2048
Copy link
Contributor Author

The linting issue is fixed in #151, I have my FQCN fix in #161 though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants