Parameterized temp dir used during a tarball install. #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC: @zackbradys @clemenko |
dweomer
approved these changes
Nov 20, 2023
|
We fixed them. The tests should be working now. We'll take a look. |
|
fixed the tests in #176, once that's merged we can re-test and merge |
|
|
mddamato
force-pushed
the
parameterize-tarball-tmp-dir
branch
from
f44e1a7
to
8aa7564
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
During a tarball install the rke2 executable will be run from a temporary directory created in the system default temp directroy (usually
/tmp), which means the install will fail when/tmpis mounted with thenoexecoption.This PR parameterizes the path to the parent directory of the temporary directory that gets created by adding the
tarball_temp_dirvariable, while leaving it to the system default iftarball_temp_diris not specified.Which issue(s) this PR fixes:
Fixes #172
Special notes for your reviewer:
N/A
Testing
Tested performing tarball installs with
tarball_temp_dirundefined and defined to point to a path other than the system default temp dir.Release Notes
Parameterized tmp dir used during a tarball install.