Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allowing templates to be applied AFTER the cluster is fully up #181

Conversation

aleiner
Copy link
Contributor

@aleiner aleiner commented Jan 10, 2024

What type of PR is this?

(REQUIRED)

  • bug
  • cleanup
  • documentation
  • feature

What this PR does / why we need it:

(REQUIRED)

Allows for manifest files to be applied after the cluster is up. Current functionality only allows for manifests to be applied after the first server node is up.

Which issue(s) this PR fixes:

(REQUIRED)

Fixes #180

@aleiner aleiner linked an issue Jan 10, 2024 that may be closed by this pull request
@aleiner aleiner requested a review from mddamato January 10, 2024 20:10
roles/cluster_manifest/vars/main.yml Outdated Show resolved Hide resolved
roles/cluster_manifest/defaults/main.yml Outdated Show resolved Hide resolved
@aleiner aleiner merged commit 104f126 into main Jan 16, 2024
5 checks passed
@aleiner aleiner deleted the 180-allow-for-manifests-to-be-applied-after-the-cluster-is-fully-up branch January 19, 2024 20:23
@jcox10
Copy link
Contributor

jcox10 commented Mar 6, 2024

How is this different than the add-manifest-addons.yml? It should be at least documented in inventory/sample/group_vars/rke2_servers.yml at the bare minimum.

@aleiner
Copy link
Contributor Author

aleiner commented Mar 27, 2024

@jcox10 - Thanks for keeping us honest. PR has been submitted to address the additional documentation.

We will rework some of the logic before a new release where the variable names may change to make things more streamlined.

@mddamato
Copy link
Contributor

@jcox10 You're correct. please see #198

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow for manifests to be applied after the cluster is fully up
3 participants