Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding support for systemd env options #242

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aleiner
Copy link
Contributor

@aleiner aleiner commented Jun 3, 2024

What type of PR is this?

(REQUIRED)

  • bug
  • cleanup
  • documentation
  • feature

What this PR does / why we need it:

It adds the optional ability to add and configure an rke-{server,agent} systemd environment file to /etc/default

Which issue(s) this PR fixes:

Fixes #169
Rework of #174

Release Notes

NONE

@Falltrades
Copy link

Hi @mddamato, @aleiner,
I tested the deployment on my side and it seems everything is working properly. Is there anything else I can help with this PR ?

@aleiner aleiner mentioned this pull request Jun 21, 2024
3 tasks
@Falltrades
Copy link

Hi @aleiner,
I wonder if the team might be interested in a PR to fix Lint warnings ? (At least for those we are seeing in this PR)

@aleiner
Copy link
Contributor Author

aleiner commented Jul 29, 2024

Hi @aleiner, I wonder if the team might be interested in a PR to fix Lint warnings ? (At least for those we are seeing in this PR)

Thanks for the offer and sorry for all of the delays. We have something in the works that we're hoping to push out soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request for Clarification [setting proxy information]
2 participants