Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature flag to allow turning on/off security group creation #73

Open
jdaws-bah opened this issue Mar 6, 2023 · 2 comments
Open

Feature flag to allow turning on/off security group creation #73

jdaws-bah opened this issue Mar 6, 2023 · 2 comments

Comments

@jdaws-bah
Copy link

Governance policies often times prevent the creation of Security Groups, so heavy modifications are needed to use the rke2-aws-tf repository in our environment. A feature flag is requested to turn on/off the creation of the Security Groups and pass our own pre-existing values. The implementation should mimic the IAM modules feature flag.

@jdaws-bah
Copy link
Author

Additionally, we currently can't pass in target group arns to the agent-nodepool module, even though the nodepool module accepts a target_group_arns variable. I'd like to be able to pass target group arns if I so chose.

@aleiner
Copy link
Contributor

aleiner commented Mar 31, 2023

Thanks for the feedback - a pending PR has been submitted, (#74), which will be reviewed as a potential fix for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants