Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add server readiness elb health checks configuration options #106

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

joelmccoy
Copy link

Fixes #105 .

This PR adds in configuration options to the terraform module so that we can have better health checks for the rke2 server nodes. It introduces the ability to set the server nodes autoscaling health check to ELB (ref).

Also added additional configuration options:

  • enforce_min_elb_capcity which checks to make sure all server nodes are up before terraform proceeds
  • server_node_health_check_grace_period allows you to override the default 300s before considering an instance healthy
  • wait_for_elb_capacity_on_updates enables enforce_min_elb_capacity for autoscaling group updates (and not just initial creation)

All these changes are added in a nonbreaking change manner (default values are set to originals).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No ability to set Server Nodepool Autoscaling Health Check to ELB instead of EC2
1 participant