You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jun 6, 2018. It is now read-only.
Right now the normalization functions return a zero-length vector if run on the zero vector. This can lead to subtle problems if the code assumes the vector was correctly normalized, so we should instead assert that the incoming vector is not the zero vector.
We should also do the same for Quaternion normalization. It's much less likely to ever get a zero quaternion, but it's worth having the check for correctness (at least in debug builds).
The text was updated successfully, but these errors were encountered:
Should we only assert if all coordinates are exactly 0, or should we use an epsilon to check if all members are really close to 0? My vote is for the latter.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Right now the normalization functions return a zero-length vector if run on the zero vector. This can lead to subtle problems if the code assumes the vector was correctly normalized, so we should instead assert that the incoming vector is not the zero vector.
We should also do the same for Quaternion normalization. It's much less likely to ever get a zero quaternion, but it's worth having the check for correctness (at least in debug builds).
The text was updated successfully, but these errors were encountered: