Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert rbtmq connection pool to single connection #208

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Revert rbtmq connection pool to single connection #208

merged 1 commit into from
Aug 2, 2023

Conversation

maximusunc
Copy link
Contributor

No description provided.

@maximusunc maximusunc requested a review from cbizon July 21, 2023 20:46
@maximusunc
Copy link
Contributor Author

Bump @cbizon

cbizon
cbizon approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@cbizon cbizon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, though I have not had time to test. When we are using timeouts and keeping the messages small the problem caused by the cycling connection doesn't occur, but it's probably good to go ahead and fix anyway.

@maximusunc maximusunc merged commit 7ec3977 into main Aug 2, 2023
1 check passed
@maximusunc maximusunc deleted the remove_conn_pool branch August 2, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbizon cbizon cbizon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maximusunc @cbizon