Update heterogeneous sampling algorithm code to use the newly developed heterogeneous sampling primitve. #4922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to enh_hetero_sample
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
…to enh_hetero_sample
seunghwak
added
improvement
|
Missing some copyright year updates. |
ChuckHastings
approved these changes
Feb 7, 2025
cpp/src/c_api/neighbor_sampling.cpp
Outdated
| @@ -994,6 +994,10 @@ struct neighbor_sampling_functor : public cugraph::c_api::abstract_functor { | |||
| // otherwised throw an error and suggest the user to call uniform neighbor sample instead | |||
|
|
|||
| if (num_edge_types_ > 1) { | |||
| if (edge_types == nullptr) { | |||
There was a problem hiding this comment.
Is there a reason to prefer an explicit if statement rather than CUGRAPH_EXPECTS(edge_types == nullptr,...?
There was a problem hiding this comment.
No, I was lazy. I just copied-and-pasted-and-modified the CUGRAPH_FAIL statement from the code below. I will make an update.
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update heterogeneous sampling application code to use the new heterogeneous sampling primitive.
Breaking as the
edge_type_viewinput parameter is no longer optional (it is required for heterogeneous sampling).closes #4919