Subcharts declared in subfolders under charts/ are ignored

[consideRatio]

Frigate currently only considers Chart.yaml declared dependencies, but ignores subcharts directly located under the charts/ folder. I don't run into issues about this, but it is a broken expectation on how frigate works if I would use frigate on a helm chart wish subcharts and not just chart dependencies.

frigate/frigate/gen.py

Lines 58 to 74 in 4153bf5

	root = [] if root is None else root
	chart, values = load_chart(chartdir, root=root)
	if "dependencies" in chart:
	for dependency in chart["dependencies"]:
	dependency_name = dependency["name"]
	dependency_path = os.path.join(
	chartdir, "charts", f"{dependency_name}-{dependency['version']}.tgz",
	)
	with tempfile.TemporaryDirectory() as tmpdirname:
	shutil.unpack_archive(dependency_path, tmpdirname)
	dependency_dir = os.path.join(tmpdirname, dependency_name)
	update_chart_dependencies(tmpdirname, dependency_name)
	_, dependency_values = load_chart_with_dependencies(
	dependency_dir, root + [dependency_name]
	)
	values = squash_duplicate_values(values + dependency_values)

[consideRatio]

Note that subcharts under charts/ can be either .tgz files with a folder including a Chart.yaml, or directly folders with a Chart.yaml. Also, any .tgz file recognized to be associated with a dependency listed under Chart.yaml dependencies and to be of an outdated version, will be removed when helm dep up . is run (which is described in helm dep up --help).

[ktaletsk]

This behavior is a problem for me since I'm using Bitnami charts in my dependencies. They are packaged with a subchart in a charts/ folder, not as .tgz. This causes frigate to break.

For example, download Bitnami PostgreSQL chart: https://charts.jfrog.io/artifactory/api/helm/jfrog-charts/postgresql-13.1.0.tgz and then

frigate gen postgresql

produces the error:

FileNotFoundError: [Errno 2] No such file or directory: 'postgresql/charts/common-2.x.x.tgz'