Skip to content

Commit 971179d

Browse files
authored
Merge branch 'branch-0.12' into add-settings-icon
2 parents 9ddac2a + cbef6a8 commit 971179d

File tree

7 files changed

+23
-23
lines changed

7 files changed

+23
-23
lines changed

.github/workflows/pr.yaml

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -28,31 +28,31 @@ jobs:
2828
uses: rapidsai/shared-workflows/.github/workflows/conda-python-build.yaml@branch-24.10
2929
with:
3030
build_type: pull-request
31-
# Package is pure Python and only ever requires one build.
32-
matrix_filter: 'map(select(.ARCH == "amd64" and (.LINUX_VER | test("centos")|not))) | sort_by(.PY_VER | split(".") | map(tonumber)) | [.[-1]]'
31+
# This selects "ARCH=amd64 + the latest supported Python + CUDA".
32+
matrix_filter: map(select(.ARCH == "amd64")) | max_by([(.PY_VER|split(".")|map(tonumber)), (.CUDA_VER|split(".")|map(tonumber))]) | [.]
3333
conda-python-tests:
3434
needs: conda-python-build
3535
secrets: inherit
3636
uses: rapidsai/shared-workflows/.github/workflows/conda-python-tests.yaml@branch-24.10
3737
with:
3838
build_type: pull-request
39-
# Package is pure Python and only ever requires one build.
40-
matrix_filter: 'map(select(.ARCH == "amd64" and (.LINUX_VER | test("centos")|not))) | sort_by(.PY_VER | split(".") | map(tonumber)) | [.[-1]]'
39+
# This selects "ARCH=amd64 + the latest supported Python + CUDA".
40+
matrix_filter: map(select(.ARCH == "amd64")) | max_by([(.PY_VER|split(".")|map(tonumber)), (.CUDA_VER|split(".")|map(tonumber))]) | [.]
4141
wheel-build:
4242
needs: checks
4343
secrets: inherit
4444
uses: rapidsai/shared-workflows/.github/workflows/wheels-build.yaml@branch-24.10
4545
with:
4646
build_type: pull-request
47-
# Package is pure Python and only ever requires one build.
48-
matrix_filter: 'map(select((.LINUX_VER | test("centos")|not))) | sort_by((.PY_VER | split(".") | map(tonumber))) | [.[-1] + {ARCH: "amd64"}]'
47+
# This selects the latest supported Python + CUDA
48+
matrix_filter: max_by([(.PY_VER|split(".")|map(tonumber)), (.CUDA_VER|split(".")|map(tonumber))]) | [.]
4949
script: "ci/build_wheel.sh"
5050
wheel-tests:
5151
needs: wheel-build
5252
secrets: inherit
5353
uses: rapidsai/shared-workflows/.github/workflows/wheels-test.yaml@branch-24.10
5454
with:
5555
build_type: pull-request
56-
# Package is pure Python and only ever requires one build.
57-
matrix_filter: 'map(select(.ARCH == "amd64" and (.LINUX_VER | test("centos")|not))) | sort_by(.PY_VER | split(".") | map(tonumber)) | [.[-1]]'
58-
script: "ci/test_wheel.sh"
56+
# This selects the latest supported Python + CUDA
57+
matrix_filter: max_by([(.PY_VER|split(".")|map(tonumber)), (.CUDA_VER|split(".")|map(tonumber))]) | [.]
58+
script: "ci/test_wheel.sh"

.pre-commit-config.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,20 +2,20 @@
22

33
repos:
44
- repo: https://github.com/psf/black
5-
rev: 23.11.0
5+
rev: 24.8.0
66
hooks:
77
- id: black
88
files: jupyterlab_nvdashboard/.*
99
# Explicitly specify the pyproject.toml at the repo root, not per-project.
1010
args: ['--config', 'pyproject.toml']
1111
- repo: https://github.com/PyCQA/flake8
12-
rev: 6.1.0
12+
rev: 7.1.1
1313
hooks:
1414
- id: flake8
1515
args: ['--config=.flake8']
1616
files: jupyterlab_nvdashboard/.*$
1717
- repo: https://github.com/rapidsai/dependency-file-generator
18-
rev: v1.13.11
18+
rev: v1.14.0
1919
hooks:
2020
- id: rapids-dependency-file-generator
2121
args: ['--clean']

ci/build_wheel.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,4 +40,4 @@ python -m build -s -w
4040

4141
rapids-logger "Uploading JupyterLab NVDashboard wheels to S3"
4242
# Upload Python wheels to S3
43-
RAPIDS_PY_WHEEL_NAME="${package_name}" rapids-upload-wheels-to-s3 dist
43+
RAPIDS_PY_WHEEL_NAME="${package_name}" RAPIDS_PY_WHEEL_PURE="1" rapids-upload-wheels-to-s3 dist

ci/test_wheel.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ set -eou pipefail
77
package_name="jupyterlab-nvdashboard"
88

99
rapids-logger "Downloading artifacts from previous jobs"
10-
RAPIDS_PY_WHEEL_NAME="${package_name}" rapids-download-wheels-from-s3 ./dist
10+
RAPIDS_PY_WHEEL_NAME="${package_name}" RAPIDS_PY_WHEEL_PURE="1" rapids-download-wheels-from-s3 ./dist
1111

1212
# echo to expand wildcard before adding `[extra]` required for pip
1313
python -m pip install $(echo ./dist/jupyterlab_nvdashboard*.whl)[test]

jupyterlab_nvdashboard/apps/gpu.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,7 @@
2626

2727
# Maximum bandwidth is bidirectional, divide by 2 for separate RX & TX
2828
max_bw = (
29-
max(
30-
sum(i.value.ullVal for i in bw) * 1024**2 for bw in bandwidth
31-
)
29+
max(sum(i.value.ullVal for i in bw) * 1024**2 for bw in bandwidth)
3230
/ 2
3331
)
3432
except (IndexError, pynvml.nvml.NVMLError_NotSupported):

jupyterlab_nvdashboard/tests/test_cpu_handlers.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,10 @@ def mock_handler(monkeypatch):
1717

1818
@pytest.fixture
1919
def handler_args():
20-
with patch("tornado.web.Application") as mock_application, patch(
21-
"tornado.httputil.HTTPServerRequest"
22-
) as mock_request:
20+
with (
21+
patch("tornado.web.Application") as mock_application,
22+
patch("tornado.httputil.HTTPServerRequest") as mock_request,
23+
):
2324
# Mock the settings to return appropriate values
2425
mock_settings = {
2526
"base_url": "/",

jupyterlab_nvdashboard/tests/test_gpu_handlers.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,10 @@ def mock_handler(monkeypatch):
2323

2424
@pytest.fixture
2525
def handler_args():
26-
with patch("tornado.web.Application") as mock_application, patch(
27-
"tornado.httputil.HTTPServerRequest"
28-
) as mock_request:
26+
with (
27+
patch("tornado.web.Application") as mock_application,
28+
patch("tornado.httputil.HTTPServerRequest") as mock_request,
29+
):
2930
# Mock the settings to return appropriate values
3031
mock_settings = {
3132
"base_url": "/",

0 commit comments

Comments
 (0)