Skip to content

Commit 5f85394

Browse files
committed
Remove RAFT_BUILD_WHEELS and standardize Python builds
1 parent 8e1c62c commit 5f85394

File tree

4 files changed

+6
-24
lines changed

4 files changed

+6
-24
lines changed

ci/build_wheel_pylibraft.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,6 @@
44
set -euo pipefail
55

66
# Set up skbuild options. Enable sccache in skbuild config options
7-
export SKBUILD_CONFIGURE_OPTIONS="-DRAFT_BUILD_WHEELS=ON -DDETECT_CONDA_ENV=OFF -DFIND_RAFT_CPP=OFF"
7+
export SKBUILD_CONFIGURE_OPTIONS="-DDETECT_CONDA_ENV=OFF -DFIND_RAFT_CPP=OFF"
88

99
ci/build_wheel.sh pylibraft python/pylibraft

ci/build_wheel_raft_dask.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,6 @@
44
set -euo pipefail
55

66
# Set up skbuild options. Enable sccache in skbuild config options
7-
export SKBUILD_CONFIGURE_OPTIONS="-DRAFT_BUILD_WHEELS=ON -DDETECT_CONDA_ENV=OFF -DFIND_RAFT_CPP=OFF"
7+
export SKBUILD_CONFIGURE_OPTIONS="-DDETECT_CONDA_ENV=OFF -DFIND_RAFT_CPP=OFF"
88

99
ci/build_wheel.sh raft-dask python/raft-dask

python/pylibraft/CMakeLists.txt

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,6 @@ option(FIND_RAFT_CPP "Search for existing RAFT C++ installations before defaulti
3737
ON
3838
)
3939

40-
option(RAFT_BUILD_WHEELS "Whether this build is generating a Python wheel." OFF)
41-
4240
# If the user requested it we attempt to find RAFT.
4341
if(FIND_RAFT_CPP)
4442
find_package(raft ${pylibraft_version} REQUIRED COMPONENTS compiled)
@@ -60,16 +58,9 @@ if(NOT raft_FOUND)
6058
set(BUILD_PRIMS_BENCH OFF)
6159
set(BUILD_ANN_BENCH OFF)
6260
set(RAFT_COMPILE_LIBRARY ON)
61+
set(CUDA_STATIC_RUNTIME ON)
6362

64-
set(_exclude_from_all "")
65-
if(RAFT_BUILD_WHEELS)
66-
# Statically link dependencies if building wheels
67-
set(CUDA_STATIC_RUNTIME ON)
68-
# Don't install the raft C++ targets into wheels
69-
set(_exclude_from_all EXCLUDE_FROM_ALL)
70-
endif()
71-
72-
add_subdirectory(../../cpp raft-cpp ${_exclude_from_all})
63+
add_subdirectory(../../cpp raft-cpp EXCLUDE_FROM_ALL)
7364

7465
# When building the C++ libraries from source we must copy libraft.so alongside the
7566
# pairwise_distance and random Cython libraries TODO: when we have a single 'compiled' raft

python/raft-dask/CMakeLists.txt

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,6 @@ option(FIND_RAFT_CPP "Search for existing RAFT C++ installations before defaulti
3434
OFF
3535
)
3636

37-
option(RAFT_BUILD_WHEELS "Whether this build is generating a Python wheel." OFF)
38-
3937
# If the user requested it we attempt to find RAFT.
4038
if(FIND_RAFT_CPP)
4139
find_package(raft ${raft_dask_version} REQUIRED COMPONENTS distributed)
@@ -54,16 +52,9 @@ if(NOT raft_FOUND)
5452
set(RAFT_COMPILE_LIBRARIES OFF)
5553
set(RAFT_COMPILE_DIST_LIBRARY OFF)
5654
set(RAFT_COMPILE_NN_LIBRARY OFF)
55+
set(CUDA_STATIC_RUNTIME ON)
5756

58-
set(_exclude_from_all "")
59-
if(RAFT_BUILD_WHEELS)
60-
# Statically link dependencies if building wheels
61-
set(CUDA_STATIC_RUNTIME ON)
62-
# Don't install the raft C++ targets into wheels
63-
set(_exclude_from_all EXCLUDE_FROM_ALL)
64-
endif()
65-
66-
add_subdirectory(../../cpp raft-cpp ${_exclude_from_all})
57+
add_subdirectory(../../cpp raft-cpp EXCLUDE_FROM_ALL)
6758
list(APPEND CMAKE_MODULE_PATH ${CMAKE_BINARY_DIR}/cmake/find_modules)
6859
find_package(NCCL REQUIRED)
6960
endif()

0 commit comments

Comments
 (0)