Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Association rule troubles and mitigation ideas #1120

Closed
rasbt opened this issue Jan 14, 2025 · 3 comments
Closed

Association rule troubles and mitigation ideas #1120

rasbt opened this issue Jan 14, 2025 · 3 comments
Labels

Comments

@rasbt
Copy link
Owner

rasbt commented Jan 14, 2025

Hi all,

I received many emails about the association rule function in recent weeks. It seems to cause some various issues for some, and my apologies for that. I was also out for almost 2 months due to a travel injury and there are many other priorities I have to catch up on at the moment, so I am not sure when I will have the time to investigate this.

My suspicion is that the discrepancies you are getting (higher memory usage etc) has something to do with the 2 recent releases:

thanks for the email and note. Unfortunately, I currently don’t have the capacity to investigate further, but I suspect it had something to do with the improvements that have been made to the association rule function in the 2 recent releases in 0.23.2 and 0.23.3. (For reference, you can see there were some changes introduced in 0.23.2 and 0.23.3: https://github.com/rasbt/mlxtend/releases)

I am not sure when I will have the time to investigate more, but for an immediate solution, I suggest you try an older version. For example,

pip install mlxtend==0.23.1 -U

and see if this addresses the issue and reproduces your previous results.

I would definitely appreciate any PRs that would help mitigate potential problems here. In the worst case, I can also see if I can roll back some of the changes in the upcoming weeks or so.

@rasbt rasbt added the Bug label Jan 14, 2025
@billyes
Copy link

billyes commented Jan 17, 2025

I think this is the commit introducing the issue #1106.

@rasbt
Copy link
Owner Author

rasbt commented Jan 18, 2025

Thanks, I think you may be right. If I have the time in a few days, it would be good to re-roll back this PR to fix the common user issues. And then maybe revisit this PR more carefully. Maybe it should be a separate

If you have time and would like to contribute, PRs are always supported and appreciated, since I unfortunately have very limited time to maintain this package.

@rasbt
Copy link
Owner Author

rasbt commented Jan 26, 2025

I think the issues should be fixed now as of the latest release :)

@rasbt rasbt closed this as completed Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants