Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing of association rule lastest version #1121

Merged
merged 12 commits into from
Jan 25, 2025
Merged

Conversation

zazass8
Copy link
Contributor

@zazass8 zazass8 commented Jan 25, 2025

Code of Conduct

Description

Related issues or pull requests

Pull Request Checklist

  • Added a note about the modification or contribution to the ./docs/sources/CHANGELOG.md file (if applicable)
  • Added appropriate unit test functions in the ./mlxtend/*/tests directories (if applicable)
  • Modify documentation in the corresponding Jupyter Notebook under mlxtend/docs/sources/ (if applicable)
  • Ran PYTHONPATH='.' pytest ./mlxtend -sv and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g., PYTHONPATH='.' pytest ./mlxtend/classifier/tests/test_stacking_cv_classifier.py -sv)
  • Checked for style issues by running flake8 ./mlxtend

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@zazass8
Copy link
Contributor Author

zazass8 commented Jan 25, 2025

Hello @rasbt, so this PR links to the issues that were foreseen in #1106. In this commit, I tried to fix num_itemsets that was initially required. Now, it is an optional argument and only to be used for the case when missing values exist in the dataset.

Furthermore, it was mentioned that there was excessive memory usage when the latest version of association rules was executed. For this, the following commit uses a simplified approach of nansum as mentioned in the previous PR. Now, it seems there's no issue when the unit tests are executed. I'd assume that also this concern, is fixed.

Let me know for any feedback.

@rasbt
Copy link
Owner

rasbt commented Jan 25, 2025

Thanks a lot, that's awesome. I will merge and make a new release!

@rasbt rasbt merged commit f951cbb into rasbt:master Jan 25, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants