From 87ae67ddd9ae864833725a8d602cbbaa6303b6ef Mon Sep 17 00:00:00 2001
From: Athanaseus Javas Ramaila <aramaila@ska.ac.za>
Date: Wed, 29 Jan 2025 20:43:20 +0200
Subject: [PATCH 1/4] Update parameters.json

- remove `choices` for param of type `list`.
---
 stimela/cargo/cab/sofia2/parameters.json | 15 ++-------------
 1 file changed, 2 insertions(+), 13 deletions(-)

diff --git a/stimela/cargo/cab/sofia2/parameters.json b/stimela/cargo/cab/sofia2/parameters.json
index 0e9f79fa..15bdc077 100644
--- a/stimela/cargo/cab/sofia2/parameters.json
+++ b/stimela/cargo/cab/sofia2/parameters.json
@@ -11,7 +11,7 @@
     "parameters": [
         {
             "info": "If set to true, the pipeline will terminate with an error message if an unknown parameter name is encountered in the input parameter file. If set to false, unknown parameters will instead be ignored.", 
-            "dtype": "bool", 
+            "dtype": "bool", hoices
             "default": true, 
             "name": "pipeline.pedantic"
         }, 
@@ -501,18 +501,7 @@
                             "sum",
                             "mean"
                         ],
-            "name": "reliability.parameters",
-            "choices": [
-                "peak",
-                "sum",
-                "mean",
-                "chan",
-                "pix",
-                "fill",
-                "std",
-                "skew",
-                "kurt"
-            ]
+            "name": "reliability.parameters"
         }, 
         {
             "info": "If set to true, diagnostic plots (in EPS format) will be created to allow the quality of the reliability estimation to be assessed. It is advisable to generate and inspect these plots to ensure that the outcome of the reliability filtering procedure is satisfactory.", 

From 0f5527ece7b176eae3b5d3db994f0ca68891c46f Mon Sep 17 00:00:00 2001
From: Athanaseus Javas Ramaila <aramaila@ska.ac.za>
Date: Thu, 30 Jan 2025 12:16:53 +0200
Subject: [PATCH 2/4] Update parameters.json

---
 stimela/cargo/cab/sofia2/parameters.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/stimela/cargo/cab/sofia2/parameters.json b/stimela/cargo/cab/sofia2/parameters.json
index 15bdc077..871ccf76 100644
--- a/stimela/cargo/cab/sofia2/parameters.json
+++ b/stimela/cargo/cab/sofia2/parameters.json
@@ -11,7 +11,7 @@
     "parameters": [
         {
             "info": "If set to true, the pipeline will terminate with an error message if an unknown parameter name is encountered in the input parameter file. If set to false, unknown parameters will instead be ignored.", 
-            "dtype": "bool", hoices
+            "dtype": "bool",
             "default": true, 
             "name": "pipeline.pedantic"
         }, 

From 3d3a30dedf004029e48f66abedc24fca6bad15b0 Mon Sep 17 00:00:00 2001
From: Athanaseus Javas Ramaila <aramaila@ska.ac.za>
Date: Thu, 30 Jan 2025 15:23:27 +0200
Subject: [PATCH 3/4] Flatten the list into a string

---
 stimela/cargo/cab/sofia2/src/run.py | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/stimela/cargo/cab/sofia2/src/run.py b/stimela/cargo/cab/sofia2/src/run.py
index 20dfb833..15553946 100644
--- a/stimela/cargo/cab/sofia2/src/run.py
+++ b/stimela/cargo/cab/sofia2/src/run.py
@@ -46,6 +46,12 @@
         elif (not name == 'port2tigger'):
             value = 'false'
 
+    if name in ["reliability.parameters"] and value is not None:
+        try:
+            value = ",".join(map(str, value))  # Flatten the list into a string
+        except ValueError:
+            pass
+    
     if value is None:
         continue
     if name == "port2tigger":

From 03f60b45dc4ec0f120d8888e1957a60570c94aae Mon Sep 17 00:00:00 2001
From: Athanaseus Javas Ramaila <aramaila@ska.ac.za>
Date: Thu, 30 Jan 2025 15:30:22 +0200
Subject: [PATCH 4/4] Update run.py

---
 stimela/cargo/cab/sofia2/src/run.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/stimela/cargo/cab/sofia2/src/run.py b/stimela/cargo/cab/sofia2/src/run.py
index 15553946..4f186de2 100644
--- a/stimela/cargo/cab/sofia2/src/run.py
+++ b/stimela/cargo/cab/sofia2/src/run.py
@@ -46,7 +46,7 @@
         elif (not name == 'port2tigger'):
             value = 'false'
 
-    if name in ["reliability.parameters"] and value is not None:
+    if dtype == 'list:str' and value is not None:
         try:
             value = ",".join(map(str, value))  # Flatten the list into a string
         except ValueError: