Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DON'T MERGE: Delete unused files #116

Closed
wants to merge 1 commit into from
Closed

DON'T MERGE: Delete unused files #116

wants to merge 1 commit into from

Conversation

elsbrock
Copy link
Collaborator

These files are included in our repository but referenced nowhere.

Please don't merge this pull request, it is created only for previewing the change on http://pr-116.rzl-homepage.raumzeitlabor.org.

It is probably a good idea to run the unused-images script again.

closes #115

These files are included in our repository but referenced nowhere.

closes #115
@abrock
Copy link
Member

abrock commented Mar 24, 2015

The linkchecker doesn't find any missing images in the preview except for /assets/power_cell.png in http://pr-116.rzl-homepage.raumzeitlabor.org/blog/projekt-solar-powered-router/ which was already missing before, so I think it should be safe to force-push the change.

@elsbrock
Copy link
Collaborator Author

Thanks, will do later.

@elsbrock
Copy link
Collaborator Author

So, I just tried this using bfg. Here's what I did:

  1. git clone --bare
  2. du -sh: 262 MB
  3. run bfg
  4. expire reflog and trigger git gc
  5. du -sh: 259 MB

Unsure why we only save 3 MB. Also, bfg only supports deleting by filename (without path). Some of the files in app/assets/upload are located under app/assets and are actually used, so we should be careful here.

@abrock
Copy link
Member

abrock commented Mar 26, 2015

I managed to shrink it to 175MB: https://github.com/abrock/rzl-homepage

I took my local (slightly outdated) version where the latest commit is "Add missing image files...", then compressed all the png files using optipng -o7 and deleted every orphaned file.
Then I ran bfg etc.

@elsbrock elsbrock closed this Mar 28, 2015
@elsbrock elsbrock deleted the delete-files branch March 28, 2015 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Purge unreferenced image files
2 participants