Skip to content

Commit 32c1d1b

Browse files
authored
[Chore] Remove unused variable in volcano scheduler (#4223)
Signed-off-by: wei-chenglai <qazwsx0939059006@gmail.com>
1 parent b4cd1e2 commit 32c1d1b

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

ray-operator/controllers/ray/batchscheduler/volcano/volcano_scheduler.go

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ import (
2626
)
2727

2828
const (
29-
PodGroupName = "podgroups.scheduling.volcano.sh"
3029
pluginName = "volcano"
3130
QueueNameLabelKey = "volcano.sh/queue-name"
3231
NetworkTopologyModeLabelKey = "volcano.sh/network-topology-mode"
@@ -87,10 +86,11 @@ func (v *VolcanoBatchScheduler) handleRayJob(ctx context.Context, rayJob *rayv1.
8786
}
8887

8988
func getSubmitterResource(rayJob *rayv1.RayJob) corev1.ResourceList {
90-
if rayJob.Spec.SubmissionMode == rayv1.K8sJobMode {
89+
switch rayJob.Spec.SubmissionMode {
90+
case rayv1.K8sJobMode:
9191
submitterTemplate := common.GetSubmitterTemplate(&rayJob.Spec, rayJob.Spec.RayClusterSpec)
9292
return utils.CalculatePodResource(submitterTemplate.Spec)
93-
} else if rayJob.Spec.SubmissionMode == rayv1.SidecarMode {
93+
case rayv1.SidecarMode:
9494
submitterContainer := common.GetDefaultSubmitterContainer(rayJob.Spec.RayClusterSpec)
9595
containerResource := submitterContainer.Resources.Requests
9696
for name, quantity := range submitterContainer.Resources.Limits {
@@ -99,8 +99,9 @@ func getSubmitterResource(rayJob *rayv1.RayJob) corev1.ResourceList {
9999
}
100100
}
101101
return containerResource
102+
default:
103+
return corev1.ResourceList{}
102104
}
103-
return corev1.ResourceList{}
104105
}
105106

106107
func getAppPodGroupName(object metav1.Object) string {

0 commit comments

Comments
 (0)