Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Cover cpplint for /src/ray/object_manager (excluding plasma) #51084

Open
elimelt opened this issue Mar 5, 2025 · 2 comments
Open

[core] Cover cpplint for /src/ray/object_manager (excluding plasma) #51084

elimelt opened this issue Mar 5, 2025 · 2 comments
Assignees
Labels
core Issues that should be addressed in Ray Core enhancement Request for new feature and/or capability

Comments

@elimelt
Copy link

elimelt commented Mar 5, 2025

Description

As part of the initiative to introduce cpplint into the pre-commit hook, we are gradually cleaning up C++ folders to ensure compliance with code style requirements. This issue focuses on cleaning up src/ray/object_manager (excluding plasma, as it's being covered through #50954).

Goal

Ensure all .h and .cc files in src/ray/raylet_client comply with cpplint rules.
Address or suppress all cpplint warnings.

Steps to Complete

  • Checkout the latest main branch and install the pre-commit hook.
  • Manually modify all C++ files in src/ray/raylet_client to trigger cpplint (e.g., by adding a newline).
  • Run git commit to trigger cpplint and identify issues.
  • Fix the reported issues or suppress them using clang-tidy if necessary.

This is a sub issue from #50583

@dentiny
Copy link
Contributor

dentiny commented Mar 5, 2025

Thanks! Appreciate your help.

@dentiny dentiny added enhancement Request for new feature and/or capability core Issues that should be addressed in Ray Core labels Mar 5, 2025
@elimelt
Copy link
Author

elimelt commented Mar 5, 2025

Code changes done, just waiting for checks to pass before marking ready for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Issues that should be addressed in Ray Core enhancement Request for new feature and/or capability
Projects
None yet
Development

No branches or pull requests

2 participants