Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Guard ray C++ code quality via unit test #51086

Open
dentiny opened this issue Mar 5, 2025 · 1 comment
Open

[core] Guard ray C++ code quality via unit test #51086

dentiny opened this issue Mar 5, 2025 · 1 comment
Labels
core Issues that should be addressed in Ray Core enhancement Request for new feature and/or capability help-wanted P2 Important issue, but not time-critical

Comments

@dentiny
Copy link
Contributor

dentiny commented Mar 5, 2025

Description

Ray core C++ components are not properly unit tested:

  • As people left, it's less confident to guard against improper code change with missing context;
  • Sanitizer on CI is only triggered on unit test;
  • Unit test coverage is a good indicator of code quality (i.e. 85% branch coverage).

Use case

No response
@dentiny dentiny added core Issues that should be addressed in Ray Core enhancement Request for new feature and/or capability P2 Important issue, but not time-critical help-wanted labels Mar 5, 2025
@dentiny
Copy link
Contributor Author

dentiny commented Mar 5, 2025

Any unit test for uncovered classes / functions are welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core Issues that should be addressed in Ray Core enhancement Request for new feature and/or capability help-wanted P2 Important issue, but not time-critical
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dentiny