Neovim removed/replaced 0.10 deprecated API

Author: ray-x

README.md

@@ -4,7 +4,7 @@
 
 - Easy code navigation, view diagnostic errors, see relationships of functions, variables
 
-- A plugin combines the power of LSP and 🌲🏡 Treesitter together. Not only provids a better highlight but also help you analyse symbol context effectively.
+- A plugin combines the power of LSP and 🌲🏡 Treesitter together. Not only provides a better highlight but also help you analyse symbol context effectively.
 
 - ctags fuzzy search & build ctags symbols
 
@@ -140,7 +140,7 @@ I'd like to go beyond what the system is offering.
 
 ## Install
 
-Require nvim-0.6.1 or above, nightly (0.8) prefered
+Require nvim-0.9 or above, nightly (0.10 or greater) preferred
 
 You can remove your lspconfig setup and use this plugin.
 The plugin depends on lspconfig and [guihua.lua](https://github.com/ray-x/guihua.lua), which provides GUI and fzy support(migrate from [romgrk's project](romgrk/fzy-lua-native)).
@@ -364,7 +364,7 @@ require'navigator'.setup({
     diagnostic_virtual_text = true,  -- show virtual for diagnostic message
     diagnostic_update_in_insert = false, -- update diagnostic message in insert mode
     display_diagnostic_qf = true, -- always show quickfix if there are diagnostic errors, set to false if you want to ignore it
-                                  -- set to 'trouble' to show diagnositcs in Trouble
+                                  -- set to 'trouble' to show diagnostcs in Trouble
     tsserver = {
       filetypes = {'typescript'} -- disable javascript etc,
       -- set to {} to disable the lspclient for all filetypes
@@ -401,7 +401,7 @@ require'navigator'.setup({
       sumneko_root_path = vim.fn.expand("$HOME") .. "/github/sumneko/lua-language-server",
       sumneko_binary = vim.fn.expand("$HOME") .. "/github/sumneko/lua-language-server/bin/macOS/lua-language-server",
     },
-    servers = {'cmake', 'ltex'}, -- by default empty, and it should load all LSP clients avalible based on filetype
+    servers = {'cmake', 'ltex'}, -- by default empty, and it should load all LSP clients available based on filetype
     -- but if you want navigator load  e.g. `cmake` and `ltex` for you , you
     -- can put them in the `servers` list and navigator will auto load them.
     -- you could still specify the custom config  like this
@@ -425,7 +425,7 @@ local servers = {
 }
 ```
 
-Navigator will try to load avalible lsp server/client based on filetype. The clients has none default on_attach.
+Navigator will try to load available lsp server/client based on filetype. The clients has none default on_attach.
 incremental sync and debounce is enabled by navigator. And the lsp
 snippet will be enabled. So you could use COQ and nvim-cmp snippet expand.
 
@@ -572,7 +572,7 @@ LspDiagnosticsXXX are used for diagnostic. Please check highlight.lua and dochig
   - treesitter (list treesitter symbols, object analysis)
   - lsp-signature (better signature help)
 
-The plugin can be loaded lazily (packer `opt = true` ), And it will check if optional plugins existance and load those plugins only if they existed.
+The plugin can be loaded lazily (packer `opt = true` ), And it will check if optional plugins existence and load those plugins only if they existed.
 
 The terminal will need to be able to output nerdfont and emoji correctly. I am using Kitty with nerdfont (Victor Mono).
 
@@ -778,16 +778,16 @@ You can override the above highlight to fit your current colorscheme
 | command         | function                                                                  |
 | --------------- | ------------------------------------------------------------------------- |
 | LspToggleFmt    | toggle lsp auto format                                                    |
-| LspKeymaps      | show LSP releated keymaps                                                 |
+| LspKeymaps      | show LSP related keymaps                                                  |
 | Nctags {args}   | show ctags symbols, args: -g regen ctags                                  |
 | LspRestart      | reload lsp                                                                |
 | LspToggleFmt    | toggle lsp format                                                         |
 | LspSymbols      | document symbol in side panel                                             |
-| LspAndDiag      | document symbol and diagnostics in side panel                                             |
+| LspAndDiag      | document symbol and diagnostics in side panel                             |
 | NRefPanel       | show symbol reference in side panel                                       |
 | TSymbols        | treesitter symbol in side panel                                           |
-| TsAndDiag        | treesitter symbol and diagnostics in side panel                                           |
-| Calltree {args} | lsp call hierarchy call tree, args: -i (incomming default), -o (outgoing) |
+| TsAndDiag       | treesitter symbol and diagnostics in side panel                           |
+| Calltree {args} | lsp call hierarchy call tree, args: -i (incoming default), -o (outgoing)  |
 
 ## Screenshots
 
@@ -866,7 +866,7 @@ You can in place edit your code in floating window
 
 <https://user-images.githubusercontent.com/1681295/121832919-89cbc080-cd0e-11eb-9778-11d0f356b38d.mov>
 
-(Note: This feature only avalible in `find reference` and `find diagnostic`, You can not add/remove lines in floating window)
+(Note: This feature only available in `find reference` and `find diagnostic`, You can not add/remove lines in floating window)
 
 ### Implementation
 
@@ -897,7 +897,7 @@ You can in place edit your code in floating window
 Treetsitter symbols in all buffers
 ![treesitter](https://user-images.githubusercontent.com/1681295/118734953-cc6eba00-b882-11eb-9db8-0a052630d57e.jpg?raw=true)
 
-### Call hierarchy (incomming/outgoing calls)
+### Call hierarchy (incoming/outgoing calls)
 
 ![incomming_calls](https://user-images.githubusercontent.com/1681295/142348079-49b71486-4f16-4f10-95c9-483aad11c262.jpg)
 
@@ -987,7 +987,7 @@ end
 
 ## API and extensions
 The plugin built on top of guihua, you can extend the plugin based on your requirements.
-e.g. A side pannel of lsp symbols and lsp diagnostics:
+e.g. A side panel of lsp symbols and lsp diagnostics:
 
 
 ```lua
@@ -1040,10 +1040,11 @@ end
 
 ## Errors and Bug Reporting
 
-- Please double check your setup and check if minium setup works or not
-- It should works for 0.6.1, neovim 0.8.x prefered.
+- Please double check your setup and check if minimum setup works or not
+- It should works for 0.6.1, neovim 0.8.x preferred.
 - Check console output
 - Check `LspInfo` and treesitter status with `checkhealth`
 - Turn on log and attach the log to your issue if possible you can remove any personal/company info in the log
-- Submit Issue with minium vimrc. Please check playground/init.lua as a vimrc template. !!!Please DONOT use a packer vimrc.
-  That installs everything to default folder!!! Also check this repo [navigator bug report](https://github.com/fky2015/navigator.nvim-bug-report)
+- Submit Issue with minium init.lua. Please check playground/init.lua as a vimrc template.
+  Also check this repo [navigator bug report](https://github.com/fky2015/navigator.nvim-bug-report) on how to report bug
+  with minimum setup.

lua/navigator.lua

@@ -186,16 +186,16 @@ _NgConfigValues = {
 
     -- Diagnostics (floating window)
     diagnostic_head_severity_1 = '🈲',
-    diagnostic_head_severity_2 = '☣️',
-    diagnostic_head_severity_3 = '👎',
+    diagnostic_head_severity_2 = '🛠️',
+    diagnostic_head_severity_3 = '🔧',
     diagnostic_head_description = '👹', -- suffix for severities
     diagnostic_virtual_text = '🦊', -- floating text preview (set to empty to disable)
     diagnostic_file = '🚑', -- icon in floating window, indicates the file contains diagnostics
 
     -- Values (floating window)
     value_definition = '🐶🍡', -- identifier defined
     value_changed = '📝', -- identifier modified
-    context_separator = '  ', -- separator between text and value
+    context_separator = ' ', -- separator between text and value
 
     -- Formatting for Side Panel
     side_panel = {
@@ -206,7 +206,7 @@ _NgConfigValues = {
       outer_node = '╰○',
       bracket_left = '⟪',
       bracket_right = '⟫',
-      tab = '󰌒'
+      tab = '󰌒',
     },
     fold = {
       prefix = '⚡',
@@ -247,6 +247,10 @@ M.deprecated = function(cfg)
     warn('ts_fold option changed, refer to README for more details')
     cfg.ts_fold = { enable = cfg.ts_fold }
   end
+  local has_nvim_011 = vim.fn.has('nvim-0.11.0')
+  if not has_nvim_011 then
+    vim.lsp.get_clients = vim.lsp.get_active_clients
+  end
 end
 
 local extend_config = function(opts)
@@ -381,15 +385,19 @@ M.setup = function(cfg)
       _NgConfigValues.loaded = true
     end
 
-    if _NgConfigValues.ts_fold.enable == true and not vim.tbl_contains(_NgConfigValues.ts_fold.disable_filetypes, vim.o.filetype) and not vim.wo.diff then
+    if
+      _NgConfigValues.ts_fold.enable == true
+      and not vim.tbl_contains(_NgConfigValues.ts_fold.disable_filetypes, vim.o.filetype)
+      and not vim.wo.diff
+    then
       require('navigator.foldts').on_attach()
     end
 
     local _start_client = vim.lsp.start_client
     vim.lsp.start_client = function(lsp_config)
       -- add highlight for Lspxxx
       require('navigator.lspclient.highlight').add_highlight()
-      require('navigator.lspclient.highlight').diagnositc_config_sign()
+      require('navigator.lspclient.highlight').config_signs()
       -- require('navigator.lspclient.mapping').setup()
       require('navigator.lspclient.lspkind').init()
       return _start_client(lsp_config)

lua/navigator/cclshierarchy.lua

@@ -14,7 +14,7 @@ local function call_hierarchy_handler(direction, err, result, ctx, cfg, error_me
   log('call_hierarchy')
   log('call_hierarchy', direction, err, result, ctx, cfg)
 
-  assert(next(vim.lsp.get_active_clients()), 'Must have a client running to use lsp_tags')
+  assert(next(vim.lsp.get_clients()), 'Must have a client running to use lsp_tags')
   if err ~= nil then
     log('hierarchy error', ctx, 'dir', direction, 'result', result, 'err', err)
     vim.notify('ERROR: ' .. error_message, vim.log.levels.WARN)
@@ -54,7 +54,7 @@ local call_hierarchy_handler_to = partial(call_hierarchy_handler, 'to')
 
 local function incoming_calls_handler(_, err, result, ctx, cfg)
   local bufnr = vim.api.nvim_get_current_buf()
-  assert(next(vim.lsp.get_active_clients({buffer = bufnr})), 'Must have a client running to use lsp_tags' )
+  assert(next(vim.lsp.get_clients({buffer = bufnr})), 'Must have a client running to use lsp_tags' )
 
   local results = call_hierarchy_handler_from(err, result, ctx, cfg, 'Incoming calls not found')
 
@@ -72,7 +72,7 @@ end
 
 function M.incoming_calls(bang, opts)
   local bufnr = vim.api.nvim_get_current_buf()
-  assert(next(vim.lsp.get_active_clients({buffer = bufnr})), 'Must have a client running to use lsp_tags' )
+  assert(next(vim.lsp.get_clients({buffer = bufnr})), 'Must have a client running to use lsp_tags' )
   -- if not lsphelper.check_capabilities("call_hierarchy") then
   --   return
   -- end
@@ -89,7 +89,7 @@ end
 
 function M.outgoing_calls(bang, opts)
   local bufnr = vim.api.nvim_get_current_buf()
-  assert(next(vim.lsp.get_active_clients({buffer = bufnr})), 'Must have a client running to use lsp_tags')
+  assert(next(vim.lsp.get_clients({buffer = bufnr})), 'Must have a client running to use lsp_tags')
   local params = vim.lsp.util.make_position_params()
   params['levels'] = 2
   params['callee'] = true

lua/navigator/codeAction.lua

@@ -81,7 +81,7 @@ function code_action:render_action_virtual_text(line, diagnostics)
   return function(err, actions, context)
     trace(actions, context)
     if context and context.client_id then
-      local cname = vim.lsp.get_active_clients({ id = context.client_id })[1].name
+      local cname = vim.lsp.get_clients({ id = context.client_id })[1].name
       if cname == 'null-ls' and _NgConfigValues.lsp.disable_nulls_codeaction_sign then
         return
       end

lua/navigator/codelens.lua

@@ -84,7 +84,7 @@ M.lsp_clients = {}
 
 function M.refresh()
   local bufnr = vim.api.nvim_get_current_buf()
-  if next(vim.lsp.get_active_clients({ buffer = bufnr })) == nil then
+  if next(vim.lsp.get_clients({ buffer = bufnr })) == nil then
     log('Must have a client running to use lsp code action')
     return
   end
@@ -124,7 +124,7 @@ M.inline = function()
   end
 
   local bufnr = api.nvim_get_current_buf()
-  if next(vim.lsp.get_active_clients({ buffer = bufnr })) == nil then
+  if next(vim.lsp.get_clients({ buffer = bufnr })) == nil then
     return
   end
   if vim.tbl_contains(M.disabled, bufnr) then

lua/navigator/definition.lua

@@ -58,7 +58,7 @@ local function get_symbol()
 end
 
 local function def_preview(timeout_ms, method)
-  assert(next(vim.lsp.get_active_clients({ buffer = 0 })), 'Must have a client running')
+  assert(next(vim.lsp.get_clients({ buffer = 0 })), 'Must have a client running')
   method = method or 'textDocument/definition'
   local params = vim.lsp.util.make_position_params()
   local result = vim.lsp.buf_request_sync(0, method, params, timeout_ms or 1000)