From 9218d2f3fe64728fd2b022f045798ceab67258e4 Mon Sep 17 00:00:00 2001 From: YashK Date: Thu, 11 Apr 2024 18:39:09 +0530 Subject: [PATCH] refactor: requested changes --- accounts/accounts.go | 4 +--- cmd/vote_test.go | 9 +++++---- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/accounts/accounts.go b/accounts/accounts.go index 97681ee5..4284ed6a 100644 --- a/accounts/accounts.go +++ b/accounts/accounts.go @@ -13,9 +13,7 @@ import ( "strings" ) -var ( - log = logger.NewLogger() -) +var log = logger.NewLogger() //This function takes path and password as input and returns new account func (am *AccountManager) CreateAccount(keystorePath string, password string) accounts.Account { diff --git a/cmd/vote_test.go b/cmd/vote_test.go index 5349b5ef..72ac46e8 100644 --- a/cmd/vote_test.go +++ b/cmd/vote_test.go @@ -280,19 +280,20 @@ func TestCalculateSecret(t *testing.T) { accountManager := accounts.NewAccountManager(testKeystorePath) account := accounts.InitAccountStruct(tt.args.address, tt.args.password, accountManager) gotSignature, gotSecret, err := cmdUtils.CalculateSecret(account, tt.args.epoch, testKeystorePath, tt.args.chainId) + if (err != nil) != tt.wantErr { + t.Errorf("CalculateSecret() error = %v, wantErr %v", err, tt.wantErr) + return + } gotSignatureInHash := hex.EncodeToString(gotSignature) gotSecretInHash := hex.EncodeToString(gotSecret) + if !reflect.DeepEqual(gotSignatureInHash, tt.wantSignature) { t.Errorf("CalculateSecret() Signature = %v, want %v", gotSignatureInHash, tt.wantSignature) } if !reflect.DeepEqual(gotSecretInHash, tt.wantSecret) { t.Errorf("CalculateSecret() Secret = %v, want %v", gotSecretInHash, tt.wantSecret) } - if (err != nil) != tt.wantErr { - t.Errorf("CalculateSecret() error = %v, wantErr %v", err, tt.wantErr) - return - } }) } }