From 08e2c543387d144ed590f1743ebf64e88927b4b1 Mon Sep 17 00:00:00 2001 From: Chaitanya Deorukhkar Date: Fri, 24 Nov 2023 17:16:20 +0530 Subject: [PATCH] chore: move @table-library to dependencies (#1845) --- .changeset/moody-moles-change.md | 6 ----- .../docs/guides/Installation.stories.mdx | 10 ------- packages/blade/package.json | 26 +++++++------------ .../Table/docs/BasicTable.stories.tsx | 1 - 4 files changed, 9 insertions(+), 34 deletions(-) diff --git a/.changeset/moody-moles-change.md b/.changeset/moody-moles-change.md index 6443543a611..96308ffe4e2 100644 --- a/.changeset/moody-moles-change.md +++ b/.changeset/moody-moles-change.md @@ -3,9 +3,3 @@ --- feat: Add `Table` component - -### Usage Instructions for Table component -- If you want to use Table component from Blade, make sure you install the following dependencies to your project before using Table -```bash -yarn add @table-library/react-table-library @emotion/react -``` diff --git a/packages/blade/docs/guides/Installation.stories.mdx b/packages/blade/docs/guides/Installation.stories.mdx index d9c511aee55..9594262d8b9 100644 --- a/packages/blade/docs/guides/Installation.stories.mdx +++ b/packages/blade/docs/guides/Installation.stories.mdx @@ -48,19 +48,9 @@ Blade has a peer dependency on a few libraries, you can skip adding it if you al > > Currently, blade only supports styled-components v5 only - `@floating-ui/react` - - `@table-library/react-table-library` (If you want to use the [Table component](/?path=/docs/components-table--table)) - - `@emotion/react` (If you want to use the [Table component](/?path=/docs/components-table--table)) - ```shell yarn add @razorpay/blade styled-components@5.3.11 @floating-ui/react ``` -
- - #### For Table Component - ```shell - yarn add @table-library/react-table-library @emotion/react - ``` - 2. Follow [this guide](#-install-fonts) to install the fonts. 3. For **React Native** projects you need to do additional setup for the peer dependencies: diff --git a/packages/blade/package.json b/packages/blade/package.json index 64af5578097..b5a29691602 100644 --- a/packages/blade/package.json +++ b/packages/blade/package.json @@ -115,16 +115,18 @@ }, "dependencies": { "@babel/runtime": "7.20.0", + "@emotion/react": "11.11.1", + "@floating-ui/react-native": "0.10.1", + "@floating-ui/react": "0.25.4", + "@table-library/react-table-library": "4.1.7", "@types/body-scroll-lock": "3.1.0", "@use-gesture/react": "10.2.24", "body-scroll-lock": "4.0.0-beta.0", - "use-presence": "1.1.0", - "@floating-ui/react": "0.25.4", - "@floating-ui/react-native": "0.10.1", "patch-package": "7.0.0", - "tinycolor2": "1.6.0", + "react-native-pager-view": "6.2.1", "react-native-tab-view": "3.5.2", - "react-native-pager-view": "6.2.1" + "tinycolor2": "1.6.0", + "use-presence": "1.1.0" }, "devDependencies": { "chromatic": "6.22.0", @@ -135,7 +137,6 @@ "@babel/preset-react": "7.16.5", "@babel/preset-typescript": "7.16.5", "@codesandbox/sandpack-react": "1.16.0", - "@emotion/react": "11.11.1", "@gorhom/bottom-sheet": "4.4.6", "@gorhom/portal": "1.0.14", "@react-native/metro-config": "0.72.9", @@ -187,7 +188,6 @@ "@types/tinycolor2": "1.4.3", "@types/react-router-dom": "5.3.3", "@types/storybook-react-router": "1.0.5", - "@table-library/react-table-library": "4.1.7", "any-leaf": "1.2.2", "args-parser": "1.3.0", "babel-jest": "29.6.1", @@ -241,8 +241,6 @@ "typescript-transform-paths": "3.4.6" }, "peerDependencies": { - "@table-library/react-table-library": "^4.1.7", - "@emotion/react": "^11.11.1", "@gorhom/bottom-sheet": "^4", "@gorhom/portal": "1.0.14", "@floating-ui/react": "0.25.4", @@ -266,12 +264,6 @@ }, "@gorhom/bottom-sheet": { "optional": true - }, - "@table-library/react-table-library": { - "optional": true - }, - "@emotion/react": { - "optional": true } }, "resolutions": { @@ -321,14 +313,14 @@ "name": "Import Button only", "path": "./build/components/index.production.web.js", "import": "{ Button }", - "limit": "20 kb", + "limit": "30 kb", "running": false }, { "name": "Import Text only", "path": "./build/components/index.production.web.js", "import": "{ Text }", - "limit": "15 kb", + "limit": "25 kb", "running": false } ] diff --git a/packages/blade/src/components/Table/docs/BasicTable.stories.tsx b/packages/blade/src/components/Table/docs/BasicTable.stories.tsx index 5e9ce2df884..6716a5beeb0 100644 --- a/packages/blade/src/components/Table/docs/BasicTable.stories.tsx +++ b/packages/blade/src/components/Table/docs/BasicTable.stories.tsx @@ -44,7 +44,6 @@ export default { docs: { page: () => (