Skip to content

Commit cf5797f

Browse files
committed
chore: fix tests
1 parent fbb78e8 commit cf5797f

File tree

2 files changed

+9
-40
lines changed

2 files changed

+9
-40
lines changed

packages/blade/src/components/ButtonGroup/__tests__/ButtonGroup.web.test.tsx

Lines changed: 1 addition & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ import { Button } from '~components/Button/Button';
77
import { ChevronDownIcon, PlusIcon } from '~components/Icons';
88
import { Dropdown, DropdownButton, DropdownOverlay } from '~components/Dropdown';
99
import { ActionList, ActionListItem } from '~components/ActionList';
10-
import { AutoComplete } from '~components/Input/DropdownInputTriggers';
1110

1211
beforeAll(() => jest.spyOn(console, 'error').mockImplementation());
1312
afterAll(() => jest.restoreAllMocks());
@@ -168,40 +167,7 @@ describe('<ButtonGroup />', () => {
168167
</ButtonGroup>,
169168
),
170169
).toThrowError(
171-
'[Blade: ButtonGroup]: Only "Button" or "Dropdown" component with Button trigger are allowed as children.',
172-
);
173-
});
174-
175-
it('should throw error with invalid dropdown children', () => {
176-
expect(() =>
177-
renderWithTheme(
178-
<ButtonGroup>
179-
<Button icon={PlusIcon}>Payout</Button>
180-
<Dropdown selectionType="single">
181-
<AutoComplete
182-
label="City"
183-
placeholder="Select your City"
184-
name="action"
185-
onChange={({ name, values }) => {
186-
console.log({ name, values });
187-
}}
188-
onInputValueChange={({ name, value }) => {
189-
console.log({ name, value });
190-
}}
191-
/>
192-
<DropdownOverlay>
193-
<ActionList>
194-
<ActionListItem title="Mumbai" value="mumbai" />
195-
<ActionListItem title="Pune" value="pune" />
196-
<ActionListItem title="Bangalore" value="bangalore" />
197-
<ActionListItem title="Mysore" value="mysore" />
198-
</ActionList>
199-
</DropdownOverlay>
200-
</Dropdown>
201-
</ButtonGroup>,
202-
),
203-
).toThrowError(
204-
'[Blade: ButtonGroup]: Only "Button" or "Dropdown" component with Button trigger are allowed as children.',
170+
'[Blade: ButtonGroup]: Only `Button, Dropdown, Tooltip, Popover` components are accepted in `ButtonGroup` children',
205171
);
206172
});
207173
});

packages/blade/src/utils/useControllable.web.test.tsx

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
/* eslint-disable @typescript-eslint/no-explicit-any */
12
import userEvent from '@testing-library/user-event';
23
import React from 'react';
34
import renderWithTheme from './testing/renderWithTheme.web';
@@ -10,18 +11,20 @@ const Example = ({
1011
}: {
1112
value?: number;
1213
defaultValue?: number;
13-
onChange?: (value: number) => void;
14+
onChange?: (value: number, extra: any) => void;
1415
}): React.ReactElement => {
1516
const [_value, setValue] = useControllableState({
1617
value,
1718
defaultValue: defaultValue ?? 0,
18-
onChange,
19+
onChange: (value, extraData) => {
20+
onChange?.(value, extraData);
21+
},
1922
});
2023

2124
return (
2225
<button
2326
onClick={() => {
24-
setValue((prev) => prev + 1);
27+
setValue((prev) => prev + 1, false, 'extra');
2528
}}
2629
>
2730
{_value}
@@ -87,11 +90,11 @@ describe('useControllableState', () => {
8790
const user = userEvent.setup();
8891
await user.click(getByRole('button'));
8992

90-
expect(onChange).toHaveBeenCalledWith(2);
93+
expect(onChange).toHaveBeenCalledWith(2, 'extra');
9194
expect(onChange).toHaveBeenCalledTimes(1);
9295

9396
await user.click(getByRole('button'));
94-
expect(onChange).toHaveBeenCalledWith(3);
97+
expect(onChange).toHaveBeenCalledWith(3, 'extra');
9598
expect(onChange).toHaveBeenCalledTimes(2);
9699
});
97100
});

0 commit comments

Comments
 (0)