Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Carousel onChange fires on parent component re render #1863

Closed
Akshay090 opened this issue Dec 4, 2023 · 2 comments
Closed

Carousel onChange fires on parent component re render #1863

Akshay090 opened this issue Dec 4, 2023 · 2 comments
Assignees
@anuraghazra
Labels
bug P1 Kinda Important

Comments

@Akshay090
Copy link
Contributor

Stackblitz link

When the parent component re renders the onChange of Carousel fires, which shouldn't be happening 😿
@saurabhdaware saurabhdaware added the P0 Critical label Dec 6, 2023
@anuraghazra anuraghazra added P1 Kinda Important and removed P0 Critical labels Dec 6, 2023
@AritraLeo
Copy link
Contributor

So the problem is from Slide 3/4 it comes back to Slide 1 when next is clicked (onChange is triggered). If I am missing something please let me know and if this is the exact problem then I am on it please provide me the link to the page in your repo

@anuraghazra
Copy link
Member

Fixed in #1895

@anuraghazra anuraghazra self-assigned this Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anuraghazra anuraghazra

Labels
bug P1 Kinda Important
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Akshay090 @saurabhdaware @anuraghazra @AritraLeo