-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Request to update twitter to x icon [Fixes #2371] #2372
fix: Request to update twitter to x icon [Fixes #2371] #2372
Conversation
|
✅ PR title follows Conventional Commits specification. |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3d90a6b:
|
@saurabhdaware Kindly review the changes |
Thanks for the PR. I'll get it reviewed from our design team and get back |
Meanwhile
|
Hey @sarthak-kumar-shailendra , I got it reviewed from design team but this icon doesn't match the design guidelines we have set for icons. To follow consistency with other icons, we have certain roundness and boldness that is defined in our design icon guidelines. We also have an automated script to sync figma design icons with code so this change will be done by our design team based on our design guideline and later the automated script will create the PR to add it to icons. Thanks for the effort and for creating the issue though. We'll keep your issue open and close it when we fix it with automated script. I see you've also created the other PR for documentation's UI fix which seems good to me. I have suggested one small change. We can merge that one. |
Description
The Twitter logo has been changed and hasn't been updated on this site. [Fixes #2371]
Changes
Old icon
New icon
Component Checklist