Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Request to update twitter to x icon [Fixes #2371] #2372

Conversation

sarthak-kumar-shailendra
Copy link
Contributor

Description

The Twitter logo has been changed and hasn't been updated on this site. [Fixes #2371]

Changes

Old icon
Screenshot 2024-10-05 at 1 23 46 AM

New icon
Screenshot 2024-10-05 at 1 26 07 AM

Component Checklist

  • Update Component Status Page
  • Perform Manual Testing in Other Browsers
  • Add KitchenSink Story
  • Add Interaction Tests (if applicable)
  • Add changeset

Copy link

changeset-bot bot commented Oct 4, 2024

⚠️ No Changeset found

Latest commit: 3d90a6b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 4, 2024

✅ PR title follows Conventional Commits specification.

@sarthak-kumar-shailendra sarthak-kumar-shailendra changed the title Request to update twitter to x icon [Fixes #2371] fix: Request to update twitter to x icon [Fixes #2371] Oct 4, 2024
Copy link

codesandbox-ci bot commented Oct 4, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3d90a6b:

Sandbox Source
razorpay/blade: basic Configuration

@sarthak-kumar-shailendra
Copy link
Contributor Author

@saurabhdaware Kindly review the changes

@saurabhdaware
Copy link
Member

Thanks for the PR. I'll get it reviewed from our design team and get back

@saurabhdaware
Copy link
Member

Meanwhile

  • can you add changeset (you can click the link in changeset comment)
  • Update snapshots (You can locally run yarn test:react -u and yarn test:react-native -u and commit changes)

@saurabhdaware
Copy link
Member

Hey @sarthak-kumar-shailendra , I got it reviewed from design team but this icon doesn't match the design guidelines we have set for icons. To follow consistency with other icons, we have certain roundness and boldness that is defined in our design icon guidelines.

We also have an automated script to sync figma design icons with code so this change will be done by our design team based on our design guideline and later the automated script will create the PR to add it to icons.

Thanks for the effort and for creating the issue though. We'll keep your issue open and close it when we fix it with automated script.

I see you've also created the other PR for documentation's UI fix which seems good to me. I have suggested one small change. We can merge that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request to update twitter to x icon in the blade ui library
2 participants