From 0cbc76fb2431cbfbad7e76c3006ec8826cd34201 Mon Sep 17 00:00:00 2001 From: Sumitmaithani Date: Thu, 11 Jul 2024 00:10:26 +0530 Subject: [PATCH 1/4] fix: table footer background color --- packages/blade/src/components/Table/TablePagination.web.tsx | 3 ++- packages/blade/src/components/Table/types.ts | 5 +++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/packages/blade/src/components/Table/TablePagination.web.tsx b/packages/blade/src/components/Table/TablePagination.web.tsx index 007a595e93a..eb7e09c1b77 100644 --- a/packages/blade/src/components/Table/TablePagination.web.tsx +++ b/packages/blade/src/components/Table/TablePagination.web.tsx @@ -141,6 +141,7 @@ const _TablePagination = ({ currentPage: controlledCurrentPage, onPageChange, onPageSizeChange, + backgroundColor = tablePagination.backgroundColor, defaultPageSize = tablePagination.defaultPageSize, showPageSizePicker = true, showPageNumberSelector = false, @@ -242,7 +243,7 @@ const _TablePagination = ({ display="flex" flexDirection="row" padding={tablePagination.padding} - backgroundColor={tablePagination.backgroundColor} + backgroundColor={backgroundColor} > {showLabel && !onMobile && ( diff --git a/packages/blade/src/components/Table/types.ts b/packages/blade/src/components/Table/types.ts index 52c89ecf0b2..2b01452faa9 100644 --- a/packages/blade/src/components/Table/types.ts +++ b/packages/blade/src/components/Table/types.ts @@ -354,6 +354,11 @@ type TablePaginationCommonProps = { * @default false */ showLabel?: boolean; + /** + * The background color of the component. + * @default transparent + */ + backgroundColor?: string; }; type TablePaginationType = 'client' | 'server'; From c9955ca6c52411a31b591716b5302b715fa113aa Mon Sep 17 00:00:00 2001 From: Sumitmaithani Date: Fri, 12 Jul 2024 16:33:43 +0530 Subject: [PATCH 2/4] fix: req change --- packages/blade/src/components/Table/TablePagination.web.tsx | 2 +- packages/blade/src/components/Table/types.ts | 5 ----- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/packages/blade/src/components/Table/TablePagination.web.tsx b/packages/blade/src/components/Table/TablePagination.web.tsx index eb7e09c1b77..43a880fa76e 100644 --- a/packages/blade/src/components/Table/TablePagination.web.tsx +++ b/packages/blade/src/components/Table/TablePagination.web.tsx @@ -141,7 +141,6 @@ const _TablePagination = ({ currentPage: controlledCurrentPage, onPageChange, onPageSizeChange, - backgroundColor = tablePagination.backgroundColor, defaultPageSize = tablePagination.defaultPageSize, showPageSizePicker = true, showPageNumberSelector = false, @@ -156,6 +155,7 @@ const _TablePagination = ({ totalItems, setPaginationRowSize, setPaginationType, + backgroundColor, } = useTableContext(); const [currentPageSize, setCurrentPageSize] = React.useState(defaultPageSize); const [currentPage, setCurrentPage] = React.useState( diff --git a/packages/blade/src/components/Table/types.ts b/packages/blade/src/components/Table/types.ts index 2b01452faa9..52c89ecf0b2 100644 --- a/packages/blade/src/components/Table/types.ts +++ b/packages/blade/src/components/Table/types.ts @@ -354,11 +354,6 @@ type TablePaginationCommonProps = { * @default false */ showLabel?: boolean; - /** - * The background color of the component. - * @default transparent - */ - backgroundColor?: string; }; type TablePaginationType = 'client' | 'server'; From 97f76221d8e56a17e120edd65c2e8a6f046b55c8 Mon Sep 17 00:00:00 2001 From: Chaitanya Deorukhkar Date: Mon, 15 Jul 2024 11:08:07 +0530 Subject: [PATCH 3/4] Create curly-roses-peel.md --- .changeset/curly-roses-peel.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/curly-roses-peel.md diff --git a/.changeset/curly-roses-peel.md b/.changeset/curly-roses-peel.md new file mode 100644 index 00000000000..3e340b74178 --- /dev/null +++ b/.changeset/curly-roses-peel.md @@ -0,0 +1,5 @@ +--- +"@razorpay/blade": patch +--- + +fix: table footer background color From 092c03105d2fb90223b2b3c15772b295ff499e9c Mon Sep 17 00:00:00 2001 From: Sumitmaithani Date: Mon, 15 Jul 2024 18:08:17 +0530 Subject: [PATCH 4/4] fix: removed tablePagination.backgroundColor --- packages/blade/src/components/Table/tokens.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/blade/src/components/Table/tokens.ts b/packages/blade/src/components/Table/tokens.ts index d696703843b..d43815e662f 100644 --- a/packages/blade/src/components/Table/tokens.ts +++ b/packages/blade/src/components/Table/tokens.ts @@ -99,7 +99,6 @@ const tableToolbar = { } as const; const tablePagination = { - backgroundColor: 'transparent', padding: 'spacing.4', pageSelectionButton: { backgroundColor: 'transparent',