-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better highlight failures in case a job is skipped but is required to succeed #31
Comments
Yeah, even just red would be enough. Normally, you only look at the output (at least in my case) when the check fails, so you only care about the failed jobs. If we go with just ❌, I'd suggest to put it somewhere at the start though, so that it is in the same position on every line which then helps your eyes more easily scan the jobs and find the offending one. |
@tomasr8 thanks for documenting this! I've been meaning to do something about it. I think @pradyunsg was the first one to give the same feedback, but I never got around to actually doing anything about it… @hugovk GitHub Job Summaries allow markdown, which has the same limitation as any comments on the platform (like this one). They don't allow arbitrary HTML, so coloring anything there would not be possible. But for the job logs, it should be possible to use regular ANSI escape codes. We'd just need to separate these outputs and format them differently. And perhaps respect |
Here's an example from the CPython repo:
https://github.com/python/cpython/actions/runs/13328394772
With this many checks, it's hard to see at a first glance what went wrong (hint: it's the
cross-build-linux
job):I think we can highlight this type of failure so that it's easier to spot among all the other jobs. Thoughts?
The text was updated successfully, but these errors were encountered: