Build failing due as dependency is not resolved #51
Comments
|
I have similar issue. Others too. See here: doczjs/docz#1102 As v5 "removed a lot of code" (https://github.com/react-bootstrap/dom-helpers/blob/master/CHANGELOG.md#500-2019-08-30) maybe if v5 is loaded some helpers are missing? |
|
I tried fixing dom-helpers version to 5.1.0 or 3.4.0 using the resolutions feature of yarn. Did not help. |
|
@barbalex Do you have dom-helpers duplication in react-transition-group? |
|
@TrySound Not sure what you mean but maybe you mean this part from yarn.lock: |
|
Usually folks who hit this sort of thing have altered webpaks resolve config such that either packages are flattened incorrectly or webpavk looks in the wrong directory first when resolving. Worth making sure you don't have anything fishy in your webpavk config |
|
And here comes why: |
|
I added this to package.json and now it builds: "resolutions": {
"react-transition-group": "4.0.0"
}@TrySound thanks for pointing to react-transition-group |
|
So yarn incorrectly resolved this? I usually have this problem in big monorepos. Second yarn call on user side helps to generate proper lockfile. |
|
This is still not working for me. If I force dom-helpers to v5 I get errors but also if I force it to v3 - just different ones. Same when I force react-transition-group which depending on its version uses dom-helpers v5 or v3. I feel that dom-helpers must have had breaking changes that were not explained in: changelog.md, releases or the readme. Have I missed the documentation? I am now attempting to create a pull-request do update scroll-behavior to use dom-helpers v5. I am running into problems though, due to the changes in dom-helpers not being documented. Some of the imports could be updated by using flat imports. But some not. These three imports should be altered, but where have the modules gone? for I have tried and it seems to work. Is that correct? |
|
It's not dom-helpers issue. The package released with major bump. Don't force it in resolutions. You should have two different versions in your node_modules. One can be hoisted and one should be in nested node_modules. |
|
Yeah, the version number change quite clearly signals that this could happen. I am using At the same time I am using I guess this is what causes the problem. Two questions: Udating the dependency tree Solving the conflict
How would I achieve that? |
|
Hm.. I don't see react-swipeable-views uses material-ui. |
|
yep, that was wrong, sorry. But the fact remains that am using react-swipeable-views uses dom-helpers in v3 while @material-ui/core@4.4.2 uses dom-helpers v5. |
|
Do you see |
|
Extracts from yarn.lock: |
|
Well, I see you have a resolution somewhere. Remove it and reinstall material-ui |
|
No, not any more. I had one a few yarn calls ago but that should not show in yarn.lock any more. package.json: {
"name": "artdaten",
"version": "1.1.7",
"author": {
"name": "Alexander Gabriel",
"email": "alex@gabriel-software.ch",
"url": "https://gabriel-software.ch"
},
"private": true,
"dependencies": {
"@apollo/react-hooks": "3.1.0",
"@loadable/component": "5.10.2",
"@material-ui/core": "4.4.2",
"@material-ui/icons": "4.4.1",
"apollo-cache-inmemory": "1.6.3",
"apollo-client": "2.6.4",
"apollo-link": "1.2.13",
"apollo-link-batch-http": "1.2.13",
"apollo-link-context": "1.0.19",
"apollo-link-http": "1.5.16",
"autosuggest-highlight": "3.1.1",
"babel-plugin-styled-components": "1.10.6",
"copy-to-clipboard": "3.2.0",
"create-react-class": "15.6.3",
"date-fns": "2.1.0",
"dexie": "2.0.4",
"docz": "2.0.0-rc.39",
"exceljs": "2.0.1",
"file-saver": "2.0.2",
"gatsby": "2.15.14",
"gatsby-plugin-create-client-paths": "2.1.7",
"gatsby-plugin-eslint": "2.0.5",
"gatsby-plugin-manifest": "2.2.16",
"gatsby-plugin-offline": "3.0.6",
"gatsby-plugin-react-helmet": "3.1.7",
"gatsby-plugin-styled-components": "3.1.5",
"gatsby-plugin-typography": "2.3.7",
"gatsby-plugin-web-font-loader": "1.0.4",
"gatsby-source-filesystem": "2.1.22",
"gatsby-theme-docz": "2.0.0-rc.39",
"graphiql": "0.14.2",
"graphql-tag": "2.10.1",
"is-uuid": "1.0.2",
"isomorphic-fetch": "2.2.1",
"js-file-download": "0.4.8",
"json2csv": "4.5.3",
"jwt-decode": "2.2.0",
"lodash": "4.17.15",
"mobx": "5.13.0",
"mobx-react-lite": "1.4.1",
"mobx-state-tree": "3.14.1",
"react": "16.9.0",
"react-autosuggest": "9.4.3",
"react-contextmenu": "2.11.0",
"react-data-grid": "6.1.0",
"react-dom": "16.9.0",
"react-dropzone": "10.1.8",
"react-error-boundary": "1.2.5",
"react-fns": "1.4.0",
"react-helmet": "5.2.1",
"react-linkify": "0.2.2",
"react-measure": "2.3.0",
"react-reflex": "3.0.16",
"react-swipeable-views": "0.13.3",
"react-typography": "0.16.19",
"react-window": "1.8.5",
"recompose": "0.30.0",
"styled-components": "4.3.2",
"typeface-roboto": "0.0.75",
"typography": "0.16.19",
"workerize-loader": "1.1.0",
"xlsx": "0.15.1"
},
"dependenciesComments": {
"exceljs": "Do not upgrade past 1.10.0, will break in production. See: https://github.com/exceljs/exceljs/issues/871, https://github.com/exceljs/exceljs/issues/948",
"remove-flow-types-loader": "needed because graphiql causes warnings: https://github.com/graphql/graphiql/issues/617#issuecomment-398237987"
},
"devDependencies": {
"@graphile-contrib/pg-order-by-related": "1.0.0-beta.6",
"@typescript-eslint/eslint-plugin": "1.x",
"@typescript-eslint/parser": "1.x",
"babel-eslint": "10.x",
"copyfiles": "2.1.1",
"docsify-cli": "4.3.0",
"eslint": "6.3.0",
"eslint-config-react-app": "5.0.1",
"eslint-loader": "3.0.0",
"eslint-plugin-import": "2.x",
"eslint-plugin-jsx-a11y": "6.x",
"eslint-plugin-react": "7.x",
"eslint-plugin-react-hooks": "2.0.1",
"postgraphile": "4.4.3",
"postgraphile-plugin-connection-filter": "1.1.3",
"postgraphile-upsert-plugin": "1.0.5",
"react-scripts": "3.1.1",
"remove-flow-types-loader": "1.1.0",
"shx": "0.3.2",
"source-map-explorer": "2.0.1"
},
"scripts": {
"build": "gatsby build",
"build2": "gatsby clean && gatsby build && copyfiles now.json public && copyfiles api/**/* public/api",
"buildArtdaten": "gatsby clean && gatsby build && shx cp nowArtdaten.json public/now.json && copyfiles api/**/* public/api",
"clean": "gatsby clean",
"dev": "gatsby develop",
"start": "npm run develop",
"serve": "gatsby serve",
"analyze": "npx source-map-explorer build/static/js/main.*",
"startDocs": "yarn docsify serve ./docs --port 8000"
},
"license": "ISC",
"eslintConfig": {
"extends": "react-app"
},
"browserslist": [
">0.2%",
"not dead",
"not ie > 0",
"not op_mini all"
]
} |
|
Show me what I asked in |
|
Do you mean I should check the files in the node_modules folder?
|
|
Well, I see node_modules are correct. Not yarn problem, not dom-helpers problem. I guess webpack resolver in docz broken. They resolve dom-helpers only from root though there is nested v5 in react-transition-group. Ask there. |
|
I actually saw same a lot of times with CRA, Gatsby and Next.js. They all webpack based and somehow modified webpack resolver. |
|
@TrySound Thanks for great help. So looks like @jquense was right too in #51 (comment). Thanks to both! |
|
@TrySound I am running into problems though, due to the changes in dom-helpers not being documented or me not finding the documentation. Some of the imports could be updated by using flat imports. But some not. These three imports should be altered: for I have tried and it seems to work. Hope that is correct. But what about dom-helpers/events/off and ..on? |
|
@ thanks is not simply ? |
|
The code looks similar |
|
@elyazinho Remove dom-helpers resolutions if you added them and remove |
|
hi @TrySound i haven't added any dom-helpers resolution nor modified the webpack config, so how do i resolve this error? ie how do i raise an issue in the webpack wrapper? what are the steps? error is as such: |
|
What do you use gatsby, docz, cra? |
|
@TrySound cra |
|
I resolved rm -rf node_modules
rm package-lock.json
npm i |
Hello,
We are using "react-transition-group" version 2 and facing a build failure due to unresolved dependency. The build is successful in local system but failing when automated using atlassian bamboo as below. May I know whats going wrong here?.
ERROR in ./~/react-transition-group/CSSTransition.js build 11-Oct-2018 07:17:50 [INFO] Module not found: Error: Can't resolve 'dom-helpers/class/addClass' in '/apps/bamboo-agent-home/master-merge3/xml-data/build-dir/AV3-ACTMM3252-JOB1/ameliav3/amelia-admin-ui/node_modules/react-transition-group' build 11-Oct-2018 07:17:50 [INFO] @ ./~/react-transition-group/CSSTransition.js 8:39-76 build 11-Oct-2018 07:17:50 [INFO] @ ./~/react-transition-group/index.js build 11-Oct-2018 07:17:50 [INFO] @ ./common/amelia-common-ui/view/fr-login/FaceRecogLogin.js build 11-Oct-2018 07:17:50 [INFO] @ ./common/amelia-common-ui/containers/fr-login/FaceRecogLoginContainer.js build 11-Oct-2018 07:17:50 [INFO] @ ./src/containers/main/AdminApp.js build 11-Oct-2018 07:17:50 [INFO] @ ./src/index.js build 11-Oct-2018 07:17:50 [INFO] @ multi babel-polyfill ./src/index.js bpmn-js react react-dom path build 11-Oct-2018 07:17:50 [INFO] build 11-Oct-2018 07:17:50 [INFO] ERROR in ./~/react-transition-group/CSSTransition.js build 11-Oct-2018 07:17:50 [INFO] Module not found: Error: Can't resolve 'dom-helpers/class/removeClass' in '/apps/bamboo-agent-home/master-merge3/xml-data/build-dir/AV3-ACTMM3252-JOB1/ameliav3/amelia-admin-ui/node_modules/react-transition-group' build 11-Oct-2018 07:17:50 [INFO] @ ./~/react-transition-group/CSSTransition.js 10:42-82 build 11-Oct-2018 07:17:50 [INFO] @ ./~/react-transition-group/index.js build 11-Oct-2018 07:17:50 [INFO] @ ./common/amelia-common-ui/view/fr-login/FaceRecogLogin.js build 11-Oct-2018 07:17:50 [INFO] @ ./common/amelia-common-ui/containers/fr-login/FaceRecogLoginContainer.js build 11-Oct-2018 07:17:50 [INFO] @ ./src/containers/main/AdminApp.js build 11-Oct-2018 07:17:50 [INFO] @ ./src/index.js build 11-Oct-2018 07:17:50 [INFO] @ multi babel-polyfill ./src/index.js bpmn-js react react-dom path build 11-Oct-2018 07:17:50 [INFO] Child html-webpack-plugin for "index.html": build 11-Oct-2018 07:17:50 [INFO] [0] ./~/lodash/lodash.js 540 kB {0} [built] build 11-Oct-2018 07:17:50 [INFO] [1] ./~/html-webpack-plugin/lib/loader.js!./public/index.html 918 bytes {0} [built] build 11-Oct-2018 07:17:50 [INFO] [2] (webpack)/buildin/global.js 509 bytes {0} [built] build 11-Oct-2018 07:17:50 [INFO] [3] (webpack)/buildin/module.js 517 bytes {0} [built]The text was updated successfully, but these errors were encountered: