Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

itemRender customizes NOT list-item but <a>, so it doesn't properly support <Link> #374

Open
1aerostorm opened this issue Feb 9, 2022 · 0 comments

Comments

@1aerostorm
Copy link

I am trying to wrap each pager item into <Link> (from next/link or react-router-dom).

My code is something like following:

<Pagination
    defaultPageSize={perPage}
    itemRender={(current, type, element) => {
        return <Link href={'/base_href/' + current}>{element}</Link>
    }}
    current={page}
    total={total}
    style={{ float: 'right', margin: 0 }}
/>

Expected result:

  1. The whole pager is clickable, and makes cursor pointer.
  2. The whole pager shows hint "/base_href/..." on mouse over.
  3. Clicking each point of pager element causes navigation to the link.

Actual result:

  1. The whole pager is clickable, and makes cursor pointer.
  2. Pager shows hint "/base_href/..." on mouse over only on its center (digit), but not border.
  3. To navigate, user should click pager's center (digit), but not border.

So, it renders as:

<li>
    <Link>
        <a></a>
    </Link>
</li>

but, in order to meet expectations, it should render as:

<Link>
    <li>
        <a></a>
    </li>
</Link>

Or, at least, it should forward <li> click event to <a> element (which will fix No. 3, but not No. 2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant