Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

popupViewのeventがremoveできていない #321

Closed
S--Minecraft opened this issue May 30, 2017 · 3 comments
Closed

popupViewのeventがremoveできていない #321

S--Minecraft opened this issue May 30, 2017 · 3 comments
Labels
バグ

Comments

@S--Minecraft
Copy link
Member

removeする際には同じ関数への参照を渡す必要がある
https://github.com/readcrx-2/read.crx-2/blob/develop/src/ui/PopupView.coffee#L224

refs? #311
@S--Minecraft S--Minecraft mentioned this issue May 30, 2017
Closed
@awazi
Copy link

awazi commented May 31, 2017 •
edited
Loading

ポップアップ消滅後もpopup_sourceが残っている場合があるみたいなので、remove処理そのものに何か問題がある可能性あり。

@awazi
Copy link

awazi commented Jun 1, 2017

調べたらpopupInfo.source.off()としておけば個別に削除する必要はない、と言うことで良いのでしょうか?

@S--Minecraft
Copy link
Member Author

それができるのはjQueryのoff()ですね
これはremoveEventListener()のショートハンドのoff()なのでできません

http://blog.nocorica.jp/2015/05/js-eventlistener/

S--Minecraft added a commit that referenced this issue Jun 2, 2017
@S--Minecraft
Merge pull request #328 from awazi/issue321
2be2292 
Fix: popupViewのEventがremoveできていない close #321
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
バグ
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@S--Minecraft @awazi