fix: improve unhighlightable contents check (#170)

tefkah · JayPanoz · web-flow · commit d46f48c8ed3c · 2025-11-25T10:00:06.000Z
Co-authored-by: Jiminy Panoz &lt;JayPanoz@users.noreply.github.com&gt;
diff --git a/navigator-html-injectables/src/modules/Decorator.ts b/navigator-html-injectables/src/modules/Decorator.ts
@@ -103,8 +103,10 @@ class DecorationGroup {
                 // The common ancestor is an element that definitely cannot be highlighted
                 this.notTextFlag?.set(id, true);
             }
-            if(ancestor.querySelector(cannotNativeHighlight.join(", ").toLowerCase())) {
-                // Contains elements that definitely cannot be highlighted as children
+            // Check if the range itself contains elements that cannot be highlighted
+            const rangeFragment = range.cloneContents();
+            if(rangeFragment.querySelector(cannotNativeHighlight.join(", ").toLowerCase())) {
+                // Range contains elements that definitely cannot be highlighted
                 this.notTextFlag?.set(id, true);
             }
             if((ancestor.textContent?.trim() || "").length === 0) {

Original file line number	Diff line number	Diff line change
`@@ -103,8 +103,10 @@ class DecorationGroup {`
`103`	`103`	`// The common ancestor is an element that definitely cannot be highlighted`
`104`	`104`	`this.notTextFlag?.set(id, true);`
`105`	`105`	`}`
`106`		`- if(ancestor.querySelector(cannotNativeHighlight.join(", ").toLowerCase())) {`
`107`		`- // Contains elements that definitely cannot be highlighted as children`
	`106`	`+ // Check if the range itself contains elements that cannot be highlighted`
	`107`	`+ const rangeFragment = range.cloneContents();`
	`108`	`+ if(rangeFragment.querySelector(cannotNativeHighlight.join(", ").toLowerCase())) {`
	`109`	`+ // Range contains elements that definitely cannot be highlighted`
`108`	`110`	`this.notTextFlag?.set(id, true);`
`109`	`111`	`}`
`110`	`112`	`if((ancestor.textContent?.trim() \|\| "").length === 0) {`