Skip to content

Commit e96d53f

Browse files
committed
fix: actually include the fix
1 parent 7b3c9a6 commit e96d53f

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

navigator-html-injectables/src/modules/Decorator.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,8 +103,12 @@ class DecorationGroup {
103103
// The common ancestor is an element that definitely cannot be highlighted
104104
this.notTextFlag?.set(id, true);
105105
}
106-
if(ancestor.querySelector(cannotNativeHighlight.join(", ").toLowerCase())) {
107-
// Contains elements that definitely cannot be highlighted as children
106+
// Check if the range itself contains elements that cannot be highlighted
107+
const rangeFragment = range.cloneContents();
108+
const tempDiv = this.wnd.document.createElement('div');
109+
tempDiv.appendChild(rangeFragment);
110+
if(tempDiv.querySelector(cannotNativeHighlight.join(", ").toLowerCase())) {
111+
// Range contains elements that definitely cannot be highlighted
108112
this.notTextFlag?.set(id, true);
109113
}
110114
if((ancestor.textContent?.trim() || "").length === 0) {

0 commit comments

Comments
 (0)